Posted by greenhodge on
Per issue #2034879: [Meta] Fix documentation that refers to enabling/disabling of modules, this issue is for fixing the enable/disable to install/uninstall language in the REST module
Files:
| Comment | File | Size | Author |
|---|---|---|---|
| #31 |  fixing_enable_to_install-2318753-31.patch | 8.43 KB | Devin Carlson |
| PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,196 pass(es). [ View ] | |||
| #28 | fixing_enable_to_install-2318753-28.patch | 8.7 KB | amitgoyal |
| FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch fixing_enable_to_install-2318753-28.patch. Unable to apply patch. See the log in the details link for more information. [ View ] | |||
Comments
Comment #1
greenhodge commentedHere we will be fixing the language in the rest_help function in
rest.modulefrom:In order to use REST on a web site, you need to install and enable modules that provide
to
In order to use REST on a web site, you need to install modules that provide
Comment #2
greenhodge commentedComment #3
greenhodge commentedComment #4
Les Lim commentedComment #5
Les Lim commented+++ b/core/modules/rest/rest.module@@ -35,7 +35,7 @@
$output .= '<dt>' . t('Enabling supporting modules') . '</dt>';
"Enabling" should be "Installing" here.
Otherwise, this looks good!
Comment #6
greenhodge commentedNew patch responding to Les Lim's thing he pointed out.
Comment #7
Les Lim commentedLooks RTBC to me.
Leaving as "critical" since the parent meta is critical.
Comment #8
Les Lim commentedTaking another look.
Comment #9
Les Lim commentedCode comments throughout Rest module tests still refer to "Modules to enable."
Comment #10
Les Lim commentedComment #11
greenhodge commentedWe believe we may have finally fixed them ALL.
Comment #12
greenhodge commentedComment #13
greenhodge commentedAttempting to fix the end-of-line unhappiness
Comment #14
Les Lim commented+++ b/core/modules/rest/src/Plugin/Derivative/EntityDerivative.php@@ -122,7 +122,7 @@
+ // of module installing/uninstalling, so we simply exclude this entity
Inline code comments should still wrap at 80 characters, including the spaces in the indent.
Comment #15
Les Lim commentedComment #24
xjm commentedComment #25
xjm commentedLooks like the patches don't apply to the 8.0.x branch tip, so this will need a reroll. Thanks all!
Comment #26
xjm commentedLet's actually make the child issues normal since these are very small patches and the critical meta will still make sure completing the task blocks release.
Comment #27
greenhodge commentedComment #28
amitgoyal commentedReroll of #13 along with fixes in #14.
Comment #31
Devin Carlson commentedReroll of #28.
I also verified that it covers all of the instances of enable/disable.
Comment #32
effulgentsia commentedLooks good.
Comment #33
effulgentsia commentedComment #34
alexpott commentedThis issue is a unfrozen change (documentation) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed d3f5497 and pushed to 8.0.x. Thanks!