Posted by slashrsm on

Problem/Motivation

There are 4 functions that are not listed in the interface:
- public function aliasExists()
- public function languageAliasExists()
- public function getAliasesForAdminListing()
- public function pathHasMatchingAlias()

Proposed resolution

Add them to AliasStorageInterface.

Remaining tasks

- write patch
- review patch

User interface changes

- none

API changes

- functions added to the interface (but is not the real change as we're already pretending they are there)

Files: 
CommentFileSizeAuthor
#5 interdiff.txt2.92 KBslashrsm
#5 2354275_4.patch5.17 KBslashrsm
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,196 pass(es).
[ View ]
#1 2354275_1.patch3.73 KBslashrsm
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,150 pass(es).
[ View ]

Comments

slashrsm’s picture

slashrsm commented
Status:Active» Needs review
StatusFileSize
new 2354275_1.patch3.73 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,150 pass(es).
[ View ]
marcingy’s picture

marcingy commented
Status:Needs review» Reviewed & tested by the community

Look good

Lars Toomre’s picture

Lars Toomre commented

Does it make sense to clean up the moved doc blocks here? There are some missing type hints and no blank line between @param and @return lines. Also boolean instead of bool as a type hint.

Or should those changes be done in a separate issue?

Primsi’s picture

Primsi commented

Looks ok.

slashrsm’s picture

slashrsm commented
Status:Reviewed & tested by the community» Needs review
StatusFileSize
new 2354275_4.patch5.17 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,196 pass(es).
[ View ]
new interdiff.txt2.92 KB

Yeah, we should. Went through all comments in that file and fixed all of them. https://www.drupal.org/node/1354#types says we should use "bool".

Lars Toomre’s picture

Lars Toomre commented

Thanks @slashrsm. All of those documentation adjustments look good!

Status:Needs review» Needs work

The last submitted patch, 5: 2354275_4.patch, failed testing.

slashrsm queued 5: 2354275_4.patch for re-testing.

tim.plunkett queued 5: 2354275_4.patch for re-testing.

tim.plunkett’s picture

tim.plunkett commented
Status:Needs work» Reviewed & tested by the community

Thanks!

alexpott’s picture

alexpott commented
Status:Reviewed & tested by the community» Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed a5c5b25 and pushed to 8.0.x. Thanks!

diff --git a/core/lib/Drupal/Core/Path/AliasStorageInterface.php b/core/lib/Drupal/Core/Path/AliasStorageInterface.php
index f142f79..8d82846 100644
--- a/core/lib/Drupal/Core/Path/AliasStorageInterface.php
+++ b/core/lib/Drupal/Core/Path/AliasStorageInterface.php
@@ -67,7 +67,7 @@ public function delete($conditions);
    *
    * @param array $preloaded
    *   Paths that need preloading of aliases.
-   * @param strinng $langcode
+   * @param string $langcode
    *   Language code to search the path with. If there's no path defined for
    *   that language it will search paths without language.
    *

fixed on commit.

  • alexpott committed a5c5b25 on 8.0.x 
    Issue #2354275 by slashrsm: There are functions in AliasStorage that are...

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.