Posted by dakku on

Pedantic corrections to spelling errors..

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task
Unfrozen changes Unfrozen because it only changes typos in the UI help text.
Files: 
CommentFileSizeAuthor
#6 2374035-block_spelling-patch-2.patch2.88 KBdakku
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,812 pass(es).
[ View ]

Comments

dakku’s picture

dakku commented
Version:8.0.x-dev» 8.1.x-dev
dakku’s picture

dakku commented
StatusFileSize
new 2374035-block_spelling-patch1.patch2.21 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,087 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 2: 2374035-block_spelling-patch1.patch, failed testing.

Status:Needs work» Needs review

dakku queued 2: 2374035-block_spelling-patch1.patch for re-testing.

Status:Needs review» Needs work

The last submitted patch, 2: 2374035-block_spelling-patch1.patch, failed testing.

dakku’s picture

dakku commented
Version:8.1.x-dev» 8.0.x-dev
StatusFileSize
new 2374035-block_spelling-patch-2.patch2.88 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,812 pass(es).
[ View ]
dakku’s picture

dakku commented
Status:Needs work» Needs review
jhedstrom’s picture

jhedstrom commented
+++ b/core/modules/block/block.module
@@ -24,9 +24,9 @@ function block_help($route_name, RouteMatchInterface $route_match) {
-      $output .= '<dd>' . t('You can see which region is where in a theme by clicking an the <em>Demonstrate block regions</em> link on the <a href="!blocks">Block layout page</a>. Regions are specific to each theme, so you need to toggle to a different theme first to demonstrate its block regions.', array('!blocks' => \Drupal::url('block.admin_display'))) . '</dd>';
+      $output .= '<dd>' . t('You can see which region is where in a theme by clicking on the <em>Demonstrate block regions</em> link on the <a href="!blocks">Block layout page</a>. Regions are specific to each theme, so you need to toggle to a different theme first to demonstrate its block regions.', array('!blocks' => \Drupal::url('block.admin_display'))) . '</dd>';

I can't for the life of me see what the change/fix here is. The first change fixes an obvious duplication typo.

dakku’s picture

dakku commented

clicking an the

changed to

clicking on the

:)

jhedstrom’s picture

jhedstrom commented
Issue summary:View changes
Status:Needs review» Reviewed & tested by the community

This are both valid typo corrections.

alexpott’s picture

alexpott commented
Title:Block Module - Spelling corrections!!Block module spelling corrections
Status:Reviewed & tested by the community» Fixed

This is unfrozen change (strings), and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed c2a7d6c and pushed to 8.0.x. Thanks!

  • alexpott committed c2a7d6c on 8.0.x 
    Issue #2374035 by dakku: Block module spelling corrections

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.