Posted by sqndr on
Problem/Motivation
theme/maintenance-page.cs:
.maintenance-page {
background-color: #e0e0d8;
background-image: -webkit-radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
background-image: radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
background-repeat: repeat;
background-position: left top, 50% 50%;
min-height: 100%;
}
/* Maintenance theming */
.install-page,
.maintenance-page {
background: none;
}
It doesn't seem right to first declare a background and then immediately change set it to none. This results in a black page:
Proposed resolution
Remove the second .maintenance-page selector.
Remaining tasks
- Review the patch.
User interface changes
- Seven maintenance page looks good again.
API changes
Files:
| Comment | File | Size | Author |
|---|---|---|---|
| #6 |  wrong-rename-background.png | 186.8 KB | sqndr |
| #2 |  interdiff.txt | 390 bytes | sqndr |
| #2 |  2377449-2.patch | 443 bytes | sqndr |
| PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,382 pass(es). [ View ] | |||
| #1 | 2377449.patch | 396 bytes | sqndr |
| PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,220 pass(es). [ View ] | |||
| Screen Shot 2014-11-18 at 16.25.07.png | 72.97 KB | sqndr | |
Comments
Comment #1
sqndr commentedHere's the patch.
Comment #2
sqndr commentedIt seems like the entire block can be removed:
/* Maintenance theming */.install-page,
.maintenance-page {
background: none;
}
The
.maintenance-page {}contains a background color. The.install-page {}theming should not be in this file; and the install-page.css contains it's own background. So this should all be removed.Comment #3
sqndr commentedComment #4
sqndr commentedComment #5
LewisNyman commentedhmm this is weird, do we know which issue this regression came from?
Comment #6
sqndr commentedIt's due to a lot of renames:
maintenance-page.css version 360af27:
.maintenance-background {background-color: #e0e0d8;
background-image: -webkit-radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
background-image: radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
background-repeat: repeat;
background-position: left top, 50% 50%;
min-height: 100%;
}
/* Maintenance theming */
.install-page,
.in-maintenance {
background: none;
}
maintenance-page.css version 9d5d3b3:
.maintenance-background {background-color: #e0e0d8;
background-image: -webkit-radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
background-image: radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
background-repeat: repeat;
background-position: left top, 50% 50%;
min-height: 100%;
}
/* Maintenance theming */
.install-page,
.maintenance-page { // CHANGED FROM .in-maintenance {}
background: none;
}
maintenance-page.css version 488116d:
.maintenance-page { // CHANGED FROM .maintenance-background {}background-color: #e0e0d8;
background-image: -webkit-radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
background-image: radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
background-repeat: repeat;
background-position: left top, 50% 50%;
min-height: 100%;
}
/* Maintenance theming */
.install-page,
.maintenance-page {
background: none;
}
Comment #7
LewisNyman commentedAhh renames, that visual regression tool can't come soon enough.
Thanks!
Comment #8
sqndr commentedVisual regression tool: Woop Woop!
Comment #9
sqndr commentedJust a question though: when will people see the maintenance page/theming from Seven? Only when Seven is enabled as the default theme, right? Or are there other cases?
Comment #10
LewisNyman commentedInstall profiles can specify their own theme on install.
Comment #11
Wim Leers commented+1
#9: good question, I was wondering the same. #10, aren't there any other instances where this occurs? There should be, otherwise we wouldn't have a maintenance page style for Seven?
Comment #12
LewisNyman commentedI believe the reason we split out the styling into Seven was because of dreammarkup - #2041793: install-page.html.twig markup and CSS (bear in mind that #2169765: Redesign update.php to be more consistent with the installation process came after this)
I remember some of the comments form here: https://www.drupal.org/node/1337554#comment-7334792
Comment #13
alexpott commentedThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed c618fb8 and pushed to 8.0.x. Thanks!