Posted by tibbsa on
The editor module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
Beta phase evaluation
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
Files:
| Comment | File | Size | Author |
|---|---|---|---|
| #4 |  editor-testing-camelcase-2385225-4.patch | 19.56 KB | tibbsa |
| PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,090 pass(es). [ View ] | |||
Comments
Comment #1
tibbsa commentedComment #2
tibbsa commentedComment #3
Wim Leers commented+++ b/core/modules/editor/src/Tests/EditorLoadingTest.php@@ -52,9 +73,9 @@ protected function setUp() {
// - "untrusted": plain_text
// - "normal": plain_text, filtered_html
// - "privileged": plain_text, filtered_html, full_html
Please remove these comments, since their contents are now captured by the class-level docs that you added.
+++ b/core/modules/editor/src/Tests/EditorLoadingTest.php@@ -71,19 +92,19 @@ public function testLoading() {
- // The normal user:
+ // The privileged user:
Good catch :)
Comment #4
tibbsa commentedComment #7
areke commentedComment #8
Wim Leers commentedThanks!
Comment #9
alexpott commentedCommitted b644bff and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.