Posted by amateescu on

Since menu links are not taking the path I planned and worked towards for D8, if #2227441: New plan, Phase 1:Review the architecture and overall implementation proposal for menu links as plugins happens, this needs to happen too.

Files: 
CommentFileSizeAuthor
#5 2237625.patch337 bytesamateescu
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,181 pass(es).
[ View ]

Comments

dawehner’s picture

dawehner commented

I haz a sad :(

amateescu’s picture

amateescu commented
Parent issue:» #2178723: [meta-2] Finalize module-facing API of declaring menu links

Me too, but there are worse things in life..

pwolanin’s picture

pwolanin commented

@amateescu - so, I thought we were still largely going to be using your plan for content entities for the custom menu links. I've tried to update the summary on the #3 issue, but maybe we can discuss in more detail how we can make a system that meets all the apparent needs.

mgifford’s picture

mgifford commented
Status:Postponed» Active

Ok, so looks like this needs to be done.

amateescu’s picture

amateescu commented
Status:Active» Reviewed & tested by the community
StatusFileSize
new 2237625.patch337 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,181 pass(es).
[ View ]

Yes, definitely. #2315773: Create a menu link field type/widget/formatter is the icing on the cake, instead of being able to use entity reference for menu items (+ even supporting tree revisions at some point) we now have to invent a whole new field type.

alexpott’s picture

alexpott commented
Status:Reviewed & tested by the community» Fixed

Committed 2d4be0e and pushed to 8.0.x. Thanks @amateescu for the contributions to menu links in the D8 cycle. It's awesome that you're back in the issues making entity reference great.

  • alexpott committed 2d4be0e on 8.0.x 
    Issue #2237625 by amateescu: Step 4: Remove amateescu from the...

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.