Posted by catch on

#2366043: Upgrade to Symfony 2.6.0-beta1 got us onto 2.6 beta.

The composer update introduced a new dependency on symfony/debug via http-kernel. Before updating to 2.6 we should understand a bit more about why this was added.

Files: 
CommentFileSizeAuthor
#13 composer-symfony-debug.patch862 bytesdawehner
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,814 pass(es).
[ View ]
#6 upgrade_to_symfony_2_6-2377281-6.patch146.69 KBhussainweb
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,945 pass(es).
[ View ]
#6 composer-json-only-do-not-test.patch1.2 KBhussainweb

Comments

jibran’s picture

jibran commented
Status:Postponed» Active

Just got mail * Version 2.6 is going to be released.

webchick’s picture

webchick commented
Status:Active» Postponed

Hm. I don't see evidence of this, neither at https://github.com/symfony/symfony/tags nor https://twitter.com/symfony nor http://symfony.com/download.

Restoring postponed status for now.

hussainweb’s picture

hussainweb commented

Meanwhile, we can update to beta2. I have a new issue at #2381579: Upgrade to Symfony 2.6.0-beta2.

TJacksonVA’s picture

TJacksonVA commented

Although I should note that Symfony folks are saying that the 2.6 stable might be released this week. The release notes dated November 24th to the 2.6 Beta2 say "Symfony 2.6.0-BETA2 has just been released. This is the last version before the 2.6 final release later this week." In addition, the weekly Symfony update dated November 23rd (relating to the week of Nov 17 - Nov 23) stated "This week, Symfony project focused on tweaking and polishing all its features before the big Symfony 2.6 launch of the next week."

http://symfony.com/blog/symfony-2-6-0-beta2-released

http://symfony.com/blog/a-week-of-symfony-412-17-23-november-2014

If so, we might want to forego upgrading to Symfony 2.6 beta2 and just wait a couple of days for 2.6 stable.

hussainweb’s picture

hussainweb commented

Ah, I didn't see that post. If it is really this week, then yes, there is not much sense in going to beta2. Anyway, all the tests with beta2 are passing which is good enough for now.

hussainweb’s picture

hussainweb commented
Status:Postponed» Needs review
StatusFileSize
new composer-json-only-do-not-test.patch1.2 KB
new upgrade_to_symfony_2_6-2377281-6.patch146.69 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,945 pass(es).
[ View ]

Symfony 2.6.0 is out. I am attaching updates to composer.json and the complete patch. The command to update was composer update symfony/*

vagrant@d8:/var/www/d8task-[git 8.0.x] $ composer update symfony/*
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing symfony/class-loader (v2.6.0-BETA1)
  - Installing symfony/class-loader (v2.6.0)
    Loading from cache

  - Removing symfony/css-selector (v2.6.0-BETA1)
  - Installing symfony/css-selector (v2.6.0)
    Loading from cache

  - Removing symfony/dependency-injection (v2.6.0-BETA1)
  - Installing symfony/dependency-injection (v2.6.0)
    Downloading: 100%

  - Removing symfony/debug (v2.6.0-BETA1)
  - Installing symfony/debug (v2.6.0)
    Downloading: 100%

  - Removing symfony/http-foundation (v2.6.0-BETA1)
  - Installing symfony/http-foundation (v2.6.0)
    Downloading: 100%

  - Removing symfony/event-dispatcher (v2.6.0-BETA1)
  - Installing symfony/event-dispatcher (v2.6.0)
    Downloading: 100%

  - Removing symfony/http-kernel (v2.6.0-BETA1)
  - Installing symfony/http-kernel (v2.6.0)
    Downloading: 100%

  - Removing symfony/routing (v2.6.0-BETA1)
  - Installing symfony/routing (v2.6.0)
    Loading from cache

  - Removing symfony/serializer (v2.6.0-BETA1)
  - Installing symfony/serializer (v2.6.0)
    Loading from cache

  - Removing symfony/translation (v2.5.6)
  - Installing symfony/translation (v2.6.0)
    Downloading: 100%

  - Removing symfony/validator (v2.6.0-BETA1)
  - Installing symfony/validator (v2.6.0)
    Downloading: 100%

  - Removing symfony/yaml (v2.6.0-BETA1)
  - Installing symfony/yaml (v2.6.0)
    Loading from cache

Writing lock file
Generating autoload files

catch’s picture

catch commented
Status:Needs review» Reviewed & tested by the community

Looks good.

dawehner’s picture

dawehner commented

Nice!

alexpott’s picture

alexpott commented
Status:Reviewed & tested by the community» Fixed

This issue is a critical task and is allowed per https://www.drupal.org/core/beta-changes. Committed 93c75fa and pushed to 8.0.x. Thanks!

  • alexpott committed 93c75fa on 8.0.x 
    Issue #2377281 by hussainweb: Upgrade to Symfony 2.6 stable
Berdir’s picture

Berdir commented

the issue summary says:

The composer update introduced a new dependency on symfony/debug via http-kernel. Before updating to 2.6 we should understand a bit more about why this was added.
/blockquote>

Based on the output above, symfony/debug is still there and I can't see anything here explaining why? Should we open a new issue for that or does someone know?

catch’s picture

catch commented

Whoops, yes I think we should open a new issue to figure that out.

dawehner’s picture

dawehner commented
Issue summary:View changes
Status:Fixed» Needs review
StatusFileSize
new composer-symfony-debug.patch862 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,814 pass(es).
[ View ]

Note: This got introduced when we update to the 2.6 beta, because composer complained. (afaik this was a bug earlier)
I don't really know why, but it seems to be that we can now drop that line again.

Once I updated the composer.json file, running composer update symfony/http-kernel (that one has the dependency to symfony/debug) succeeds again.

Berdir’s picture

Berdir commented

Shouldn't there be some core/vendor code that can be removed now?

catch’s picture

catch commented
Status:Needs review» Needs work

Yes there should, at least if #13 is correct.

dawehner’s picture

dawehner commented
Status:Needs work» Needs review

Shouldn't there be some core/vendor code that can be removed now?

No, that is the confusing part about this problem:

So HttpKernel has the following composer.json file:

    "require": {
        "php": ">=5.3.3",
        "symfony/event-dispatcher": "~2.5",
        "symfony/http-foundation": "~2.5",
        "symfony/debug": "~2.6",
        "psr/log": "~1.0"
    },

For some reasons pointing to a beta version required symfony/debug to be explicitly defined, but symfony/debug is a requirement since 2.3

Berdir’s picture

Berdir commented
Status:Needs review» Reviewed & tested by the community

Did some digging, https://github.com/symfony/HttpKernel/commit/9517776f77e5488655838516fe6... moved symfony/debug from require-dev to require. Doesn't say why in that comment, though.

Anyway, looks like we're back to status quo then?

alexpott’s picture

alexpott commented
Status:Reviewed & tested by the community» Fixed

Committed d037482 and pushed to 8.0.x. Thanks!

  • alexpott committed d037482 on 8.0.x 
    Issue #2377281 followup by dawehner: Upgrade to Symfony 2.6 stable
znerol’s picture

znerol commented

Follow-up: #2385699: Use upstream AbstractEventDispatcherTest as the base class of ContainerAwareEventDispatcherTest

lussoluca’s picture

lussoluca commented
Related issues:+#2375339: Update DependencyInjection YamlFileLoader for Symfony 2.6

Please integrate also #2375339: Update DependencyInjection YamlFileLoader for Symfony 2.6 to fully use the new Symfony 2.6 functionalities

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.