| Issue 24267: | colors not right for images used outside of webview | |
| 6 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
What steps will reproduce the problem? 1. load http://caminobrowser.org/ in safari 2. load http://caminobrowser.org/ in chrome/chroimium 3. compare the site icons What is the expected output? What do you see instead? Safari has the colors right, odds are it is because we're expecting the skia rendered image to get corrected when drawn by the webview. For all image uses outside of the webview, wrong things happen. We might need to correct in all places we convert to an NSImage (bookmarks, downloads, even the aboutbox pulls it's big image from resource and hence via skia)
Nov 11, 2009
Issue 27206 has been merged into this issue.
Nov 11, 2009
Issue 26316 may or may not be related.
Dec 11, 2009
Issue 26316 isn't related; that color is determined by a HSL conversion when blending is also required and is not done.
Dec 18, 2009
Updating labels: Area-UI-Features replaces Area-BrowserUI
Labels:
-Area-BrowserUI Area-UI-Features
Jan 8, 2010
(No comment was entered for this change.)
Labels:
-Area-UI-Features Area-Feature
Feb 16, 2010
(No comment was entered for this change.)
Labels:
-Area-Feature Area-UI
Mar 9, 2010
(No comment was entered for this change.)
Labels:
wasm5kg Mstone-X
May 19, 2010
(No comment was entered for this change.)
Labels:
-wasm5kg -Mstone-X Mstone-6
May 25, 2010
(No comment was entered for this change.)
Status:
Assigned
Owner: tha...@chromium.org
Jun 18, 2010
Actively working on this? If not, can you punt to Mstone:7
Jun 18, 2010
(No comment was entered for this change.)
Labels:
-Mstone-6 Mstone-7
Aug 18, 2010
(No comment was entered for this change.)
Labels:
-Mstone-7 Mstone-8
Sep 21, 2010
(No comment was entered for this change.)
Labels:
-mstone-8 Mstone-X
Jan 12, 2011
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=71208
------------------------------------------------------------------------
r71208 | thakis@chromium.org | Wed Jan 12 11:08:26 PST 2011
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/skia/ext/skia_utils_mac.mm?r1=71208&r2=71207&pathrev=71208
M http://src.chromium.org/viewvc/chrome/trunk/src/skia/ext/skia_utils_mac.h?r1=71208&r2=71207&pathrev=71208
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_strip_controller.mm?r1=71208&r2=71207&pathrev=71208
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabpose_window.mm?r1=71208&r2=71207&pathrev=71208
Mac: Explicitly set the colorspace on SkBitmap -> CGImageRef conversions.
The color space was hardcoded as "generic rgb" in skia. This is not always correct, also skia is changing this color space around a lot currently. To protect us from their unreliable default, hardcode "generic rgb" as default on our side for now, but make it possible for clients to provide their own color space.
Use this to let tabpose and the favicon code pass in the device colorspace.
BUG=24267,50307
TEST=Open tabpose. Delayed thumbnails should look like backing-store backed thumbnails. The colors of favicons should now match other browsers.
Review URL: http://codereview.chromium.org/6117006
------------------------------------------------------------------------
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Area-UI Cr-UI
|
||||||||
| ► Sign in to add a comment | |||||||||
Labels: Mstone-5