HHVM is missing some SODIUM_CRYPTO_GENERICHASH_* constants.

see : https://www.php.net/manual/en/sodium.constants.php

the missing constants :

• const int SODIUM_CRYPTO_GENERICHASH_BYTES = 32;
• const int SODIUM_CRYPTO_GENERICHASH_BYTES_MAX = 64;
• const int SODIUM_CRYPTO_GENERICHASH_BYTES_MIN = 16;

polyfill : https://github.com/nuxed/crypto/blob/master/src/Nuxed/Crypto/_Private

I would really appreciate seeing this limitation documented a little further.

Specifically I would like to understand the issue with merge commits and know if there is a migration path from a codebase with a long history of these to one which would be ready to use fbshipit.

This should be a lint error:

$value = 42;
// ...
foreach ($arr as $value) {
  // ...
}

Same for function arguments:

function foo(int $value) {
  // ...
  foreach ($arr as $value) {
    // ...
  }
}

We allow either arrays or vecs for tuples, and arrays or dicts for shapes. We should require they match the current runtime.

This makes migration slightly harder, but the 'typeassert may return a different value' thing it creates leads to more problems.

<<__EntryPoint>>
async function site_main_async(): Awaitable<noreturn> {
   $request = Usox\HackTTP\createServerRequestFromGlobals();
   \var_dump($request->getUri()->getHost());
   exit(0);
}

$ curl -H "Host: docs.hhvm.com" http://localhost:8080
string(0) ""
$ curl http://localhost:8080
string(0) ""