Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[libzstd] Remove ZSTDMT from the shared library #1575
Merged
Conversation
* Remove ZSTDMT from the shared object by default. * Provide a macro `ZSTD_LEGACY_MULTITHREADED_API` to override it. * Document it in `lib/README.md`.
lib/README.md
Outdated
| @@ -110,6 +108,10 @@ The file structure is designed to make this selection manually achievable for an | |||
| which removes the error messages that are otherwise returned by | |||
| `ZSTD_getErrorName`. | |||
|
|
|||
| - While invoking `make libzstd`, the build macro `ZSTD_LEGACY_MULTITHREADED_API=1` | |||
| will expose the deprecated the `ZSTDMT` API exposed by `zstdmt_compress.h` in | |||
This comment has been minimized.
This comment has been minimized.
terrelln
merged commit 1a90133
into
facebook:dev
2 of 7 checks passed
2 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
terrelln commentedApr 8, 2019
ZSTD_LEGACY_MULTITHREADED_APIto override it.lib/README.md.Working on #1533