Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 31 million developers.
Sign up
Pinned
817 contributions in the last year
Activity overview
Contributed to
GoogleWebComponents/model-viewer,
PolymerLabs/html-modules-toolkit,
cdata/config
and 5 other
repositories
Contribution activity
March 2019
Created a pull request in GoogleWebComponents/model-viewer that received 8 comments
Animations
Animations
This change proposes the addition of new API (and related bug fixes) to configure and present animated glTFs with <model-viewer>. Morph,…
+1,143
−119
•
8
comments
- update to latest filament
- Animations
- Controls: Set ORBIT_FAR_PLANE to 100 too.
- StaticShadow: Avoid rendering shadow mesh when opacity is 0.
- ModelScene: Camera far plane to 100 meters instead of 1000.
- Fix broken link in readme
- fix the path to node_modules in index.html
- Renderer: Disable alpha by default.
- Added browser support section in docs site
- Stay current with the refactored Filament matrix factory functions
- Do not apply environment maps to unlit models. Fixes #374
Created an issue in GoogleWebComponents/model-viewer that received 6 comments
Support for realtime shadows
Currently our shadow is static. It is generated once up front, and can never change. Let's add support for realtime shadows (should be easy as they…
6
comments
- Materials not being cloned correctly
- Configuration to control time before displaying interaction prompt
- Control interaction prompt appears too quickly in most cases
- Update gltf_renderer to use Filament's new gltfio library
- Test suite is experiencing large numbers of timeouts
- User-configurable transform for model when placed in AR
- Built-in, optional UI for end-user control over animations
- Configurable animation iteration count
- Soft shadows
- Configuration to control if model is centered at root origin or bounding box origin
- Revisit formatting for recommended model-viewer <script> snippet
- Add documentation site formatting to support multiple <model-viewer> elements per demo
- Code formatting for documentation demo snippets is hard to read
- Add browser/polyfill support tables to online documentation
- Enable user to configure currently active animation
- Enable use of in-model camera definitions
- Support Blob and File as value types for backgroundImage and environmentImage
- Provide ESM bundle and improve compatibility recommendations
- Consider changing controls to be on by default
- Revisit dual-stage lighting configuration for PMREM/non-PMREM