Skip to content

/ php-src

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused check for struct cmsghdr #4337

Closed
wants to merge 1 commit into from
Closed

Remove unused check for struct cmsghdr #4337

wants to merge 1 commit into from

Conversation

@petk
Copy link
Member

@petk petk commented Jul 1, 2019 •
edited

The result of this check is to whether to define the HAVE_CMSGHDR symbol or not. The HAVE_CMSGHDR is never used in the code and it has been removed via 9028992.

P.S: the check is most likely not needed to be used in the code since there is a check for the presence of the header sys/socket.h...
@petk
Remove unused check for struct cmsghdr
Loading status checks…
298ea37 
The result of this check is to whether to define the HAVE_CMSGHDR symbol
or not. The HAVE_CMSGHDR is never used in the code and it has been
removed via 9028992.
@petk petk added the Build System label Jul 1, 2019
@krakjoe
krakjoe approved these changes Jul 1, 2019
View changes
@php-pulls php-pulls closed this in c70d9cd Jul 1, 2019
@petk petk deleted the petk:patch-have-cmsghdr branch Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krakjoe krakjoe

Assignees
No one assigned
Labels
Build System
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@petk @krakjoe