Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGradle include file for adding the Android dependency #7900
Conversation
|
I think is a great change. I've left you some comments! |
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
|
I agree with everything, thanks for pointing it out and for finding another source of improvement. My only doubt in this moment is: Should we move the |
|
Greetings Took the liberty of solving the merge conflict with my I hope to help, let me know if anything else I can do. |
|
@lbalmaceda does this look good to you now? |
|
@cutiko Sorry I forgot about this one. It looks good now! Thanks for the changes. |
|
It builds now, and the pages load correctly - all good to merge @lbalmaceda ? |
cb68d6f
into
auth0:master
|
Thanks @cutiko !! |
cutiko commentedJul 1, 2019
•
edited by jeffreylees
The objective of this pull request is to have one source for content about adding the Android dependency. Before this, there were at least 3 files with repeated the content, inconsistent or used deprecated instructions.
By adding an include
_gradle.md, maintenance can be done in one file only and avoids repetitive work in the rest of the documentation.An include file name
_gradle.mdwas created with the needed content. The file merge the instructions previously contained in:quickstart/native/android/_include/_auth0.mdquickstart/native/android/_include/_api_authz.mdSome edition was made to the content to make it fit between both and modularly in any other file.
In the note used before there was a link to the Github documentation. The link was removed because the documentation source file has the version hardcoded. If the documentation referred is not updated it would be inconsistent with the Maven or JCenter latest version.
A minor note about this is that the block of code was using
xmlinstead ofgroovyas code block language.While checking if there was any other repetitive usage of the Android installation explained, the reference in the file
libraries/save-and-refresh-tokens.mdwas found. It was usingcompileinstead ofimplementation, the first is deprecated. Using the include_gradle.mdthe file allows keeping the reference updated in a single place.The included usage was taken literally from the documentation, but in the files is different, so I went with my guts and stick to the guidelines.
I had problems understanding the Wordy instructions for the editor, so my apologies if anything failed on that step, however, it was followed and the editor's corrections were applied.
Update
ymlfiles are included.If this approach please you, I found a similar problem for the manifest, I could take a look later. Please let me know if there is anything else I can help with.
https://docs-content-staging-pr-7900.herokuapp.com/docs/libraries/auth0-android
https://docs-content-staging-pr-7900.herokuapp.com/docs/libraries/auth0-android/save-and-refresh-tokens
https://docs-content-staging-pr-7900.herokuapp.com/docs/quickstart/native/android