Skip to content

v5: Reuse box-shadow variables #29023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2019
Merged

v5: Reuse box-shadow variables #29023

merged 6 commits into from
Jul 15, 2019

Conversation

mdo
Copy link
Member

@mdo mdo commented Jul 13, 2019

  • Removed default <kbd> shadow
  • Add new $box-shadow-inset variable to better match multiple components' inner shadows (when enabled)
  • Reuse $box-shadow variables across several components for consistency

Fixes #23775.

@mdo mdo requested a review from a team as a code owner July 13, 2019 02:49
@mdo mdo mentioned this pull request Jul 13, 2019
Closed
@XhmikosR XhmikosR merged commit df1c3c0 into master Jul 15, 2019
@XhmikosR XhmikosR deleted the shadow-cleanup branch July 15, 2019 07:29
@MartijnCuppens MartijnCuppens mentioned this pull request Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR left review comments

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
css no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create component shadow variables to keep consistency across components
3 participants
@mdo @XhmikosR @MartijnCuppens