Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds add2app Flutter module and an iOS project to run it. #126
Conversation
|
also cc @jmagman |
|
In other places we've added the Pods/ directory to the .gitignore and not checked it in. But it depends if we want users to be able to just run from Xcode immediately without needing to run |
|
I'm seeing an error running
|
|
@johnpryan I ran into the same issue while testing a clone. There's a pod-helper script that's created by I've added a line to the podfile that will run |
|
@RedBrogdon I'm still running into a missing "podhelper.rb" error. Here's my steps:
Here's the output:
|
Just to confirm, you're on the master channel, right? |
| @@ -25,7 +25,15 @@ flutter channel stable | |||
|
|
|||
| ## Index | |||
|
|
|||
| There aren't actually any samples in here just yet. Things are coming, though! | |||
| ### [add2app](add2app) | |||
This comment has been minimized.
This comment has been minimized.
xster
Aug 12, 2019
Contributor
Sorry, I'm gonna make a crappy request. Can we replace all add2app with add-to-app?
This comment has been minimized.
This comment has been minimized.
RedBrogdon
Aug 13, 2019
Author
Contributor
Not a big deal. What about the project path? Would you prefer to see that change from add2app as well?
This comment has been minimized.
This comment has been minimized.
xster
Aug 13, 2019
Contributor
Yes please. We're trying to avoid 'clever' names and use plain english as much as possible.
|
|
||
| # Added these two lines for Flutter: | ||
| flutter_application_path = '../example_module' | ||
| system("pushd #{flutter_application_path} && flutter create . && popd") |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jmagman
Aug 13, 2019
Member
We have a thread in the Add-to-app chat about this. The podhelper.rb script is in the .gitignore, so someone who just cloned this repo needs to create it or they can't pod install. I don't really want it to be checked in, but maybe there's a better solution?
This comment has been minimized.
This comment has been minimized.
xster
Aug 13, 2019
Contributor
Ah ok. Aren't these made by running flutter packages get instead of flutter create?
This comment has been minimized.
This comment has been minimized.
RedBrogdon
Aug 13, 2019
Author
Contributor
Both work, apparently. Does flutter create also get packages?
This comment has been minimized.
This comment has been minimized.
RedBrogdon
Aug 13, 2019
Author
Contributor
Strike that, actually. When I try with flutter packages get, the script is created, but there's some other part of the module missing. I end up with an error in Xcode that states it can't find lib/main.dart.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
experimental/add2app/SimpleIOSExample/SimpleIOSExample/ViewController.swift
Outdated
Show resolved
Hide resolved
|
@xster Switching to the master channel fixed it. Now the XCode 10.3 build is failing:
|
|
PTAL. All comments addressed except for two waiting on replies. The current code builds out of the box on my machine with these steps:
@johnpryan Do you mind checking to see if a fresh copy of this PR builds for you? |
|
for future reference, |
|
LGTM cc @goderbauer, here's the sample project |
|
LGTM |
|
Yes. Please write down all outputs/stacks etc if you ever encounter any. |
RedBrogdon commentedAug 9, 2019
No description provided.