Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add_to_app README #129

Merged
merged 3 commits into from Aug 14, 2019
Merged

Update add_to_app README #129

merged 3 commits into from Aug 14, 2019

Conversation

@johnpryan
Copy link
Contributor

johnpryan commented Aug 14, 2019

No description provided.

@johnpryan johnpryan requested a review from RedBrogdon Aug 14, 2019
Copy link
Contributor

RedBrogdon left a comment

I'm not sure this is necessary. The need to use the master channel is noted at the very top of the file (lines 3-4), and while the CocoaPod issue you ran into was certainly annoying, I don't know that I'd want to peg the project to a specific version of CocoaPods. Are we, for example, going to remember in the future to test how far back we're compatible with CocoaPods and update this file as necessary?

What about instead adding a sentence in the SimpleIOSExample section that people should use the latest version, whatever that may be? That section will need to be expanded/refactored in the future anyway, since there will likely be several individual apps in the folder that will require a pod install, and we won't want to copy out the same instructions for each one.

@johnpryan
Copy link
Contributor Author

johnpryan commented Aug 14, 2019

That makes sense, I didn't see the warning. I added that the latest version of cocoapods is required to that section.

***The Add-to-App sample is designed to build with Flutter's `master` channel. See
the [README](../README.md) in the `experimental` directory for details.***
***The Add-to-App sample is designed to build with Flutter's `master` channel
and the latest version of Cocoapods. See the [README](../README.md) in the

This comment has been minimized.

@RedBrogdon

RedBrogdon Aug 14, 2019

Contributor

nit: The "p" in CocoaPods is normally capitalized.

Copy link
Contributor

RedBrogdon left a comment

Cool. LGTM!

@johnpryan johnpryan merged commit f28c525 into master Aug 14, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP Ready for review
Details
cla/google All necessary CLAs are signed
@johnpryan johnpryan deleted the add2app-readme branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.