Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 36 million developers.
Sign up
Pro
- Munich
- Munich
Popular repositories
2,023 contributions in the last year
Contribution activity
July 2019
Created a pull request in bitcoin/bitcoin that received 8 comments
init: Use InitError for all errors in bitcoind/qt
Using the same InitError for startup error in the daemon and the gui makes it possible to run the tests with the gui again: BITCOIND=bitcoin-qt ./t…
+33
−38
•
8
comments
- Remove mempool expiry, treat txs as replaceable instead
- Remove wallet settings from chainparams
- rpc: testmempoolaccept for list of transactions
- Remove unused bits from the service flags enum
- test: Add test for BIP30 duplicate tx
- test: Set BIP34Height = 2 for regtest
- test: Add tests for getblockchaininfo.softforks
- rpc: Tidy up reporting of buried and ongoing softforks
- rpc: Clarify that block count means height excl genesis
- [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts
- [wallet] Refactor AvailableCoins to pull depth from coin control
- wallet: Improve wallet creation
- refactor: share blockmetadata with BlockManager
- Clarify includeWatching for fundrawtransaction
- rpcwallet: default include_watchonly to true for watchonly wallets
- contrib: Enable building in Guix containers
- test: Enable passing wildcard test names to test runner from root
- Multiprocess build support
- Scripts and tools: Bump flake8 to 3.7.8
- Log RPC parameters (arguments) if -debug=rpcparams
- rpc: Add getblockbyheight method
- test: Add linter to make sure single parameter constructors are marked explicit
- refactor: move CCoinsViewErrorCatcher out of init.cpp
- Improve signrawtransaction error reporting
- [Tests] Suppress output in test_bitcoin for expected errors
- docs: Use placeholder instead of key expiration date
- bench: Move generated data to a dedicated translation unit
- wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction
Created an issue in bitcoin/bitcoin that received 6 comments
sendrawtransaction maxfeerate is interpreted as absolute fee by default
When the newly introduced "maxfeerate" option is not passed, the default fee rate is interpreted as an absolute amount. However, when it is passed,…
6
comments