Skip to content
#

Code review

Code review is systematic examination (sometimes referred to as peer review) of computer source code. It is intended to find mistakes overlooked in software development, improving the overall quality of software. Reviews are done in various forms such as pair programming, informal walkthroughs, and formal inspections.

Here are 200 public repositories matching this topic...

Startouf
Startouf commented Jun 21, 2018

I cannot figure out how to use properly danger on circleci 2.0 with workflows

Support I have a linear workflow where I bundle my app / install libraries (build job) and then run the tests in parallel. (I'm taking Ruby/Rspec as an example).

How can I execute Danger to report test failures on all containers ?

Currently if a job fails on circleCI, the dependent jobs are not ran (ie if I

dejay-at-work
dejay-at-work commented Dec 6, 2019

Report

What did you do?

I invoked npx danger local within a Node.js project, specifying a dangerfile.js that lives outside of the project.

Reproduction case:

#!/bin/bash
set -eu

rm -rf ./project ./tool

mkdir tool && (
  cd tool && \
  cat >dangerfile.js <<:DANGERFILE
try{
  console.log(require('array-first'));
  console.log(require('array-last'));
} catch(e) 
RMacfarlane
RMacfarlane commented Oct 2, 2019

From @chrisdias:

If I start the auth dance, then press Cancel when asked if I want to let the extension open a URL, the status bar stays at Signing into github.com.... Since I cancelled, I expect it to revert back to Sign in to github.com.

Also (just noticed this) we say into and in to. Not sure which version is right or wrong, or if its based on context :).

dpordomingo
dpordomingo commented Jan 15, 2019

from src-d/lookout#450 (comment)

Anchors pointing to titles having ., { or } inside, are generated differently by GitBook and GitHub, so when they're used, they don't work in both.

It was assumed GitBook as the preferred way to render our docs, but we should decide if we keep that rule, or if we want to look for a workaround or alternative

exampls

Wikipedia
Wikipedia

Related Topics

gerrit

Code review apps

Lucidchart Connector

Insert a public link to a Lucidchart diagram so team members can quickly understand an issue or pull request

Mergify

Pull requests automation service

Code Inspector

Code Quality, Code Reviews and Technical Debt evaluation made easy

See more Code review apps
You can’t perform that action at this time.