Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit rewrite #40

Merged
merged 145 commits into from Jan 27, 2020
Merged

Audit rewrite #40

merged 145 commits into from Jan 27, 2020

Conversation

@brianamarie
Copy link
Member

@brianamarie brianamarie commented Dec 3, 2019

This pull request is for an audit-time rewrite of the course. I will let the team know once it's ready for review.

To do:

  • make responses nice
  • include gates
  • include branch protections
  • figure out event for importing a LL course
  • Update templates - RIGHT BEFORE MERGING
    • Make sure new template repository has proper open source things
    • Delete/archive old template repository
    • Rename write-a-ll-course-template-2.0 to write-a-ll-course-template
    • Update config to reference write-a-ll-course-template
brianamarie added 3 commits Nov 29, 2019
@brianamarie brianamarie self-assigned this Dec 3, 2019
@brianamarie brianamarie added this to Triage in Learning Lab Course maintenance via automation Dec 3, 2019
@github-learning-lab github-learning-lab bot had a problem deploying to production Dec 3, 2019 Failure
@github-learning-lab
Copy link

@github-learning-lab github-learning-lab bot commented Dec 3, 2019

🔴 There was an error parsing your config.yml file.

YAMLException: duplicated mapping key at line 42, column -128:
    before:
    ^
1 similar comment
@galileo
Copy link

@galileo galileo bot commented Dec 3, 2019

🔴 There was an error parsing your config.yml file.

YAMLException: duplicated mapping key at line 42, column -128:
    before:
    ^
@github-learning-lab github-learning-lab bot had a problem deploying to production Dec 3, 2019 Failure
@galileo
Copy link

@galileo galileo bot commented Dec 3, 2019

🔴 There was an error parsing your config.yml file.

YAMLException: end of the stream or a document separator is expected at line 47, column 1:
    - title: Choose a topic for your ... 
    ^
1 similar comment
@github-learning-lab
Copy link

@github-learning-lab github-learning-lab bot commented Dec 3, 2019

🔴 There was an error parsing your config.yml file.

YAMLException: end of the stream or a document separator is expected at line 47, column 1:
    - title: Choose a topic for your ... 
    ^
@github-learning-lab github-learning-lab bot had a problem deploying to production Dec 3, 2019 Failure
@galileo
Copy link

@galileo galileo bot commented Dec 3, 2019

🔴 7 errors found in the config file.

- "steps[0].event" does not match any of the allowed types
- "steps[2].event" does not match any of the allowed types
- [Reference the template].actions[2] Action of type `merge` does not exist
- "steps[6].event" does not match any of the allowed types
- [Write a gate].actions[2] Action of type `merge` does not exist
- [Create course metadata].actions[2] Action of type `merge` does not exist
- "steps[13].event" does not match any of the allowed types
1 similar comment
@github-learning-lab
Copy link

@github-learning-lab github-learning-lab bot commented Dec 3, 2019

🔴 7 errors found in the config file.

- "steps[0].event" does not match any of the allowed types
- "steps[2].event" does not match any of the allowed types
- [Reference the template].actions[2] Action of type `merge` does not exist
- "steps[6].event" does not match any of the allowed types
- [Write a gate].actions[2] Action of type `merge` does not exist
- [Create course metadata].actions[2] Action of type `merge` does not exist
- "steps[13].event" does not match any of the allowed types
@github-learning-lab github-learning-lab bot had a problem deploying to production Dec 3, 2019 Failure
@galileo
Copy link

@galileo galileo bot commented Dec 3, 2019

🔴 1 errors found in the config file.

- [Create course metadata].actions[1] Action of type `merge` does not exist
1 similar comment
@github-learning-lab
Copy link

@github-learning-lab github-learning-lab bot commented Dec 3, 2019

🔴 1 errors found in the config file.

- [Create course metadata].actions[1] Action of type `merge` does not exist
@github-learning-lab
Copy link

@github-learning-lab github-learning-lab bot commented Dec 3, 2019

Your draft course version was created!


You can edit it using the Course Builder UI!

brianamarie added 3 commits Dec 9, 2019
brianamarie added 3 commits Dec 9, 2019
brianamarie added 8 commits Jan 21, 2020
…step 13
@brianamarie
Copy link
Member Author

@brianamarie brianamarie commented Jan 21, 2020

I'm trying to test this at its most recent version but keep running into "An unexpected error has occurred while registering for the course. Please try again later!". 😢

I've tried deleting my course and re-registering multiple times, to no avail. I've also looked at the audit log, but it's not showing that I've even tried to register for the course.

@githubtraining/learning-engineering Could you please take a peek and see if there was some problem deploying this draft course that isn't showing up in this PR?

@brianamarie
Copy link
Member Author

@brianamarie brianamarie commented Jan 22, 2020

I tried again this morning, and it worked! 🎉

@brianamarie
Copy link
Member Author

@brianamarie brianamarie commented Jan 22, 2020

Something I've noticed in my run-through:

  • Gate for step 9 is a little too strict. If there's a space after respond, it should still pass. Right?
  • I see what you mean on step 10 about keeping things consistent, @crichID. Yes, let's have the gates here match.
  • Step 13: I also see what you mean here now @crichID - let's go ahead and remove that paragraph about the title, or even better, move it to the part where it's relevant if it's not already called out there.
  • I got to create the draft! But, when I tried to join, I got "an unexpected error has occurred". It's not clear to me what this means, especially since I got this while registering for this actual course yesterday, but today it works. I'm not going to change anything here, because I'm not sure what to do.
  • Related to Gates - I would really love to be able to link the user to all examples of gates. Is there a way we can do this?

I will put some time aside to make these changes tomorrow if I can't get to them today

brianamarie added 3 commits Jan 23, 2020
@brianamarie
Copy link
Member Author

@brianamarie brianamarie commented Jan 23, 2020

I've committed fixes to the points above. I'm going to try to go through the new version of the course, and hopefully I won't end up with the same problem at the end....or any new problems 🤞

@brianamarie
Copy link
Member Author

@brianamarie brianamarie commented Jan 23, 2020

I'm noticing some strange stuff on the course landing page. It looks like the course steps are meant to populate, but they aren't. I'm also noticing some interesting formatting under the "getting help" section that I don't understand. @crichID Do you know why it looks like that?

@brianamarie
Copy link
Member Author

@brianamarie brianamarie commented Jan 23, 2020

Just finished the run-through: everything went great! I did make one small tweak to the markdown that I just adjusted, putting it in the right spot.

Except - the one thing that didn't go great, I still wasn't able to register for my own course at the end, and I don't know why. The only info I get is "An unexpected error has occurred while registering for the course. Please try again later!" The course is launched at https://lab.github.com/brianamarie/make-a-recipe-site/1.0.0. @crichID @githubtraining/learning-engineering do you have any ideas what could be going on here?

EDIT - I do know what happened there! It's an error with my new course. Since we have the troubleshooting guide, I think this should be addressed. I got an email with the debugging issue that was opened in the course once I registered. @crichID, this is ready for your review and there are no expected problems 😊

@brianamarie
Copy link
Member Author

@brianamarie brianamarie commented Jan 27, 2020

During a 1:1 with @crichID, she approved this for merge!

@brianamarie brianamarie merged commit a506d73 into master Jan 27, 2020
1 check passed
1 check passed
ci/learning-lab Your course has no errors.
Learning Lab Course maintenance automation moved this from Triage to Done Jan 27, 2020
@brianamarie brianamarie deleted the audit-rewrite branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.