Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 40 million developers.
Sign up
-
Microsoft
- Sunnyvale, CA
Pro
-
Microsoft
- Sunnyvale, CA
Popular repositories
1,290 contributions in the last year
Contribution activity
February 2020
Created a pull request in microsoft/playwright that received 2 comments
- test: add screenshot test that fails on Chromium
- feat(viewport): update defaults to 1280x720, fix Firefox
- feat(log): log only user api calls with DEBUG=pw:api
- fix(input): emit change event upon page.setInputFiles
- feat(webkit): roll webkit to r1151
- browser(webkit): do not leak contexts on windows
- fix(webkit): wait for the pipe ready on windows
- test: fix locale expectations on non-Mac
- fix(windows): wait for pipe available again
- fix(locale): document locale parameter
- fix(chromium): emit focus events in headful
- feat(coverage): expose raw v8 coverage
- feat(webkit): introduce BrowserContext({language})
- feat(webkit): roll webkit to 1148
- browser(webkit): print friendly tz names
- feat(timezone): emulate it on webkit
- browser(webkit): emulate time zone
- test: add setInputFiles input event test
- feat(active): emulate active state on webkit
- browser(webkit): emulate active and focused state
- browser(webkit): disregard dpi on windows
- feat($wait): make $wait a shortcut for waitForSelector
- feat(api): make browser.newPage own the created context
- fix(events): deliver page.close upon disconnect in FF
- fix(firefox): bring headful window to front on launch
- Some pull requests not shown.
- fix(api): browser.serviceWorker -> target.serviceWorker
- chore: make BrowserContext an interface, with 3 implementations
- feat(waitFor): update various waitFor options to be a single boolean
- test: remove `newContext` and `newPage` test helpers
- api: remove ElementHandle.visibleRatio
- feat(click): waitForInteractable option, defaults to true (#934)
- chore: strip out injected script from protocol logs
- feat(click): waitForInteractable option, defaults to true
- fix(launch): do not wait for first page in non-persistent mode
- browser(firefox): misc fixes
- feat: do not let users pass `userDataDir` to `browserType.launch()`
- fix(tests): fix test that was leaking a context
- feat(click): use browser-provided scrollIntoViewIfNeeded
- chore(tests): add types for tests
- chore(docs): assorted improvements to the readme
- browser(webkit): roll WebKit to tip-of-tree
- fix(api): page.viewport -> page.viewportSize
- fix(chromium): ensure we resume service worker before detaching from it
- test: make sure `page.fill` actually clears an input
- browser(webkit): introduce DOM.scrollIntoViewIfNeeded
- browser(firefox): introduce Page.scrollIntoViewIfNeeded
- test: expect current behavior for cross-frame js handles
- feat: introduce browserType.downloadBrowserIfNeeded()
- fix: properly nullify error stacks
- chore: Fix dead link for element handle
- Some pull request reviews not shown.
Created an issue in microsoft/playwright that received 3 comments
[BUG] Terminating the remote browser connection should clear all contexts
Consider the following scenario: const browserServer = await chromium.launchServer(); const wsEndpoint = browserServer.wsEndpoint(); const browser = …
3
comments
- [Feature] Navigation + Network + API log
- [BUG] WebKit under debug crashes on Windows
- [BUG] [WebKit] [Win] Browser.isConnected fails with
- [Feature] Richer convenience API
- [BUG] Browser / BrowserContext split is confusing
- [BUG] installing playwright and playwright-chromium downloads 2 chromiums
- [BUG] playwright-chromium and playwright have different export signatures