Skip to content

/ specifications

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCSP spec + test plan changes #724

Merged
merged 1 commit into from Feb 19, 2020
Merged

OCSP spec + test plan changes #724

merged 1 commit into from Feb 19, 2020

Conversation

@divjotarora
Copy link
Contributor

@divjotarora divjotarora commented Jan 31, 2020

A collection of spec/test fixes that I made while implementing the spec. Feel free to suggest changes I may have missed.
@divjotarora divjotarora requested review from behackett and vincentkam Jan 31, 2020
@behackett
behackett requested changes Jan 31, 2020
View changes
source/ocsp-support/ocsp-support.rst Outdated Show resolved Hide resolved
@divjotarora divjotarora requested a review from behackett Jan 31, 2020
@vincentkam
vincentkam suggested changes Jan 31, 2020
View changes
source/ocsp-support/ocsp-support.rst Outdated Show resolved Hide resolved
@divjotarora divjotarora requested a review from vincentkam Feb 3, 2020
@vincentkam
vincentkam suggested changes Feb 6, 2020
View changes
source/ocsp-support/ocsp-support.rst Outdated Show resolved Hide resolved
source/ocsp-support/ocsp-support.rst Outdated Show resolved Hide resolved
source/ocsp-support/ocsp-support.rst Outdated Show resolved Hide resolved
source/ocsp-support/tests/README.rst Outdated Show resolved Hide resolved
source/ocsp-support/tests/README.rst Show resolved Hide resolved
@divjotarora divjotarora requested a review from vincentkam Feb 6, 2020
@vincentkam
vincentkam approved these changes Feb 7, 2020
View changes
Copy link
Contributor

@vincentkam vincentkam left a comment

LGTM! 😸
@vincentkam
vincentkam suggested changes Feb 10, 2020
View changes
Copy link
Contributor

@vincentkam vincentkam left a comment

Missed one minor thing: bump the spec version and update the last updated field and changelog?
@divjotarora divjotarora requested a review from vincentkam Feb 10, 2020
@behackett
behackett reviewed Feb 12, 2020
View changes
source/ocsp-support/ocsp-support.rst Outdated Show resolved Hide resolved
@divjotarora divjotarora requested a review from behackett Feb 19, 2020
@vincentkam
vincentkam suggested changes Feb 19, 2020
View changes
source/ocsp-support/ocsp-support.rst Outdated Show resolved Hide resolved
@divjotarora divjotarora requested a review from vincentkam Feb 19, 2020
@behackett
behackett approved these changes Feb 19, 2020
View changes
Copy link
Member

@behackett behackett left a comment

lgtm
@vincentkam
vincentkam approved these changes Feb 19, 2020
View changes
Copy link
Contributor

@vincentkam vincentkam left a comment

lgtm! 😄
@divjotarora divjotarora force-pushed the divjotarora:ocsp-changes branch from 5e07940 to bd8e668 Feb 19, 2020
@divjotarora
Specify behavior for validating OCSP responses and fix test file names.
Loading status checks…
a3c9429
@divjotarora divjotarora force-pushed the divjotarora:ocsp-changes branch from bd8e668 to a3c9429 Feb 19, 2020
@divjotarora divjotarora merged commit ce5512d into mongodb:master Feb 19, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackett behackett

@vincentkam vincentkam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@divjotarora @behackett @vincentkam
You can’t perform that action at this time.