Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlite search index #114

Open
bkniffler opened this issue Jan 30, 2019 · 3 comments
Open

Sqlite search index #114

bkniffler opened this issue Jan 30, 2019 · 3 comments
Labels

Comments

@bkniffler
Copy link
Contributor

@bkniffler bkniffler commented Jan 30, 2019

Is your feature request related to a problem? Please describe.
I know you're planing to add fuzzy search through custom indexes. Sqlite has build in search indexes (FTS5) that run pretty efficiently and have scoring, highlighting, .... I'm not sure if a custom index could really ver compete with the build in one, so maybe allowing to use the native one would be pretty handy?

Describe the solution you'd like
A way to add to table schema a native fts5 index and a query method to query that index.

Additional context
https://sqlite.org/fts5.html

@ClickSimply
Copy link
Owner

@ClickSimply ClickSimply commented Jan 30, 2019

Wow, really good read. Provided some solid ideas for when the new search plugin is setup.

I think this is a good use case for an external plugin, something that you can add on top of any SQLite adapter provided the underlying SQLite has been compiled with this extension.

I'll mark this as an enhancement and add it to the development list. Keep in mind there's lots of stuff ahead of it so likely won't be able to put these features in place for a while.

@bkniffler
Copy link
Contributor Author

@bkniffler bkniffler commented Jan 30, 2019

Maybe you are right and a plugin would be better for this. I'm currently evaluating nano-sql for my app, if I decide to use it I'd give the plugin a shot. Unfortunately the syncing is a hard requirement for me, but I know you're currently trying to tick this off the list. Is there any ETA?

I really like nano-sql and the fact that you can add features so fast really vouches to the code quality, so great job on that.

I'd just recommend getting compiled js files out of the repository, they are making commits hard to understand and super cluttered.

@ClickSimply
Copy link
Owner

@ClickSimply ClickSimply commented Jan 30, 2019

Hey thanks for all the feedback, very helpful!

At this rate I'd expect the offline syncing to be done around the end of February.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.