Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMoved two animation vignettes into misc. #425
Merged
Conversation
|
@RedBrogdon we can also update the README.md and move the examples from Basics to Misc section. |
|
That's a good point, we need to update the README too. |
|
|
Yep, should have updated the README. I've pushed another commit. @johnpryan, I saw you approved, but do you mind taking another quick look? I reformatted a couple things and added a codelab link. Just want to make sure it's all good by you. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
RedBrogdon commentedApr 30, 2020
Moves the vignettes featuring AnimatedPositioned and AnimatedSwitcher from
basicstomisc.The basics section is designed to follow a particular progression of topics, easing the reader into more and more advanced bits of the animations API. For that reason, these two examples are better suited to the miscellaneous section.