Use Trio RTD theme, add readthedocs.yml #212
Merged
+274
−56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 28 28
Lines 2719 2719
=======================================
Hits 2711 2711
Misses 8 8 |
|
Thanks, that looks nice! |
pquentin
merged commit 0706f48
into
python-trio:master
16 checks passed
16 checks passed
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
RTD is failing because it installs the project via
python setup.py installbefore installingdev-requirements.txtso doesn't haveunasync. Added areadthedocs.ymlfile so we can control the install order and have RTD usepip install .instead ofpython setup.py installI also pulled most of Trio's template, it looks good for now and the docs now just need content to be improved to look really nice. No logo yet so that section is empty and didn't immediately link to the Trio Discourse. The Stackoverflow tag doesn't exist yet but doesn't hurt to link to nothing?