Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd unasync.unasync_files() API #58
Conversation
It allows to run unasync on multiple files using multiples rules if needed, without being tied to setuptools.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 97.60% 97.63% +0.03%
==========================================
Files 2 2
Lines 125 127 +2
Branches 31 31
==========================================
+ Hits 122 124 +2
Misses 1 1
Partials 2 2
|
|
I actually think this makes more sense than running Rule.unasync_files() because it's symmetrical with the build_cmdclass() interface. Maybe we can transition the Rule interface to be private with this PR :) |
Will open another PR for that + switch back to additional_replacements, then we can cut a release. |
It allows to run unasync on multiple files using multiples rules if needed, without being tied to setuptools.
@sethmlarson Now that you taught me that using Rule.unasync_files directly made sense, I'm not sure if this is such a good idea. Right now, I have a proof-of-concept that works in hip using this API:
Since I have only a single rule, I guess I could use Rule.unasync_file and loop over files. This pull request feels more general, and since I already had the code, I submitted it. Please tell me what you think.