Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVIMC-3820: Allow passing instance arg to runner #21
Conversation
r-ash
changed the title
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 88.19% 88.60% +0.41%
==========================================
Files 4 4
Lines 271 272 +1
==========================================
+ Hits 239 241 +2
+ Misses 32 31 -1
Continue to review full report at Codecov.
|
|
Nice - just update the references and required version and this one is good to go |
.travis.yml
Outdated
| @@ -10,7 +10,7 @@ after_success: | |||
| - Rscript -e 'covr::codecov()' | |||
|
|
|||
| r_github_packages: | |||
| - vimc/orderly | |||
| - vimc/orderly@vimc-3698 | |||
richfitz
May 6, 2020
Member
This can be updated now
This can be updated now
DESCRIPTION
Outdated
| @@ -10,12 +10,13 @@ Imports: | |||
| httpuv, | |||
| jsonlite, | |||
| docopt, | |||
| orderly (>= 0.7.14), | |||
| orderly (>= 1.1.14), | |||
richfitz
May 6, 2020
Member
The 3rd part of the version number is too low here - should be 1.1.34
The 3rd part of the version number is too low here - should be 1.1.34
docker/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM vimc/orderly:master | |||
| FROM vimc/orderly:vimc-3698 | |||
richfitz
May 6, 2020
Member
This can be updated
This can be updated
|
Nice, now just vimc/orderlyweb#13 to go :) |
richfitz
added a commit
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vimc/orderly#228 should be merged before this