Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upvimc-3783: Never allow multiple ids through #225
Merged
Conversation
codecov
bot
commented
May 2, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 4208 4208
=========================================
Hits 4208 4208
Continue to review full report at Codecov.
|
|
Subtle problem... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
richfitz commentedMay 2, 2020
This causes all sorts of breakage, and should be very rare. Seen when launching orderly_run in parallel, which is something we'll have to think about properly at some point