fix(docker): Not all Sentry commands work through CMD #18599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up to #16417, which assumed all commands are listed in individual modules. This was not the case and this PR broke commands like `docker run getsentry/sentry:latest export`. In this PR, we run `sentry help` and dump its output with some `sed` and `awk` magic to a file to check against. This approach is: 1. Simple 2. Serves as a simple smoke test for the image 3. Is independent of the underlying CLI libarary (not that we'll change it, but who knows).
mattrobenolt
approved these changes
May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Following up to #16417, which assumed all commands are listed in individual modules. This was not the case and this PR broke commands like
docker run getsentry/sentry:latest export.In this PR, we run
sentry helpand dump its output with somesedandawkmagic to a file to check against. This approach is: