Skip to content

/ Go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve package organizations #36

Open
eduardogr opened this issue Oct 9, 2018 · 2 comments
Open

Improve package organizations #36

eduardogr opened this issue Oct 9, 2018 · 2 comments
Labels
automated testing

Comments

@eduardogr
Copy link

@eduardogr eduardogr commented Oct 9, 2018

There's a lot of main packages in this project

sorts/selection_sort.go:1:package main
sorts/Heapsort.go:1:package main
....
....
other/PasswordGenerator.go:5:package main
other/PrimeNumbers.go:1:package main

We can improve this package organization to let each package have its place
@localleon
Copy link
Contributor

@localleon localleon commented Oct 8, 2020

+1

This would also fix all the failed golangci-lint test. Currently they fail because multiple people use the package main.
@nomisrevol
Copy link
Collaborator

@nomisrevol nomisrevol commented Oct 8, 2020

It's a good idea. I'm trying to fix this (both package and filename convention). I'm starting with sorts. You're welcome to help with other parts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automated testing
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@cclauss @eduardogr @nomisrevol @localleon
You can’t perform that action at this time.