Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
-
Google
- New York
Pro
-
Google
- New York
430 contributions in the last year
Contribution activity
May 2020
Created a pull request in google/exposure-notifications-server that received 8 comments
internal/database: add test for DB time behavior
Add a test that demonstrates why TIMESTAMP is a bad choice for DB type when a true timestamp (point in time) is desired. It does not preserve times.
+52
−0
•
8
comments
- internal/api/cleanup: clean up
- internal/database: make exposure iterator internal
- CONTRIBUTING.md: add instructions for creating secrets directory
- remove unnecessary UTC time conversions
- Use an internal iterator for ExportConfigs
- internal/database: add tests for FederationQuery and FederationSync
- internal/database: test Exposure methods
- internal/database: add a limit to the latest-batch query
- internal/database: close conn in iterator
- internal/database: add ExportBatch tests
- fix logger.Fatal calls
- internal/database: test Lock
- internal/database: test IterateExportConfigs
- use %w with fmt.Errorf
- internal/api/export: simplify some code
- internal/api/export: simplify sha256 computation
- CONTRIBUTING.md: show how to run DB tests
- migrations: add timezones to timestamps
- internal/dbtest: fix test
- internal/database: tests
- use errors.Is
- internal/api/config: remove error return
- fix bad logger calls
- internal/database: factor out common iterator code
- internal/database: improve error handling
- Some pull requests not shown.
- Adjust batch boundary conditions so that published keys hit an open batch
- Handle padded/non-padded and std/url-encoded base64
- Ensure DB_USER isn't set for go tests runs not involving test_db
- Require nonce and timestamp bounds
- put blob storage operations behind an interface
- Ensure lock can only be released by the most recent leaser.
- Add DB Migrations
Created an issue in google/exposure-notifications-server that received 1 comment
support database migration
There should be a way to change the DB schema without dropping and recreating it. We at pkg.go.dev have been happy with https://github.com/golang-m…
1
comment