Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReact eslint not catching the use of underscore with internal methods #577
Labels
Comments
|
Our style guide does have many rules and recommendations that aren't enforced by linting rules. Sometimes this is an oversight, but sometimes the linter rule doesn't exist for it. I'm not sure off the top of my head which it is. However, the guide should be discouraging My thoughts are summarized here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the React/JSX Styleguide 'Methods' section it says you shouldn't use
_to prefix internal methods. However, some of my code contains this convention and it isn't being caught by the linter. I double-checked the eslint rules for react/jsx files and there doesn't seem to be a rule defined for this convention.Is this intentional? If so, why specify the rule in your documentation? I found a related issue (#490), but it wasn't clearly stated whether or not this rule should definitely be adhered to but rather that it's more or less up to the programmer.
Any clarification would be greatly appreciated.