Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDotNet: Simplified 49.qnamaker-all-features. README corrections. #2290
+84
−203
Conversation
...s/csharp_dotnetcore/49.qnamaker-all-features/Dialog/BotQnAMakerDialog.cs
Outdated
Show resolved
Hide resolved
...s/csharp_dotnetcore/49.qnamaker-all-features/Dialog/BotQnAMakerDialog.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tracyboehrer commentedMar 31, 2020
•
edited
Simplified this sample, mainly because of a request from Doc.
QnAMakerBaseDialog really didn't do anything of value except redefine values from the real base class (QnAMakerDialog) with the same values.
RootDialog really did nothing more than fire up QnAMakerBaseDialog, which required the use of IBotServices and BotServices, none of which added much value to understanding the sample either.
Removed: RootDialog, IBotServices, BotServices.
Renamed: QnAMakerBaseDialog to BotQnAMakerDialog, and provided a constructor to give QnAMakerDialog the values it needs from config.
The README was confusing AF. The Prerequisites led me down a path of darkness from which it was difficult to return. I switched to using the steps from 11.qnamaker, which are a lot closer to the problem. Though still not perfect (Doc is looking into this issue).