Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fast_fibonacci.py #1889

Open
wants to merge 1 commit into
base: master
from
Open

Update fast_fibonacci.py #1889

wants to merge 1 commit into from

Conversation

@SandersLin
Copy link
Contributor

SandersLin commented Apr 17, 2020 •
edited

Describe your change:

added type hints.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@SandersLin
Update fast_fibonacci.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
475cdac
@cclauss
cclauss reviewed Apr 17, 2020
View changes
dynamic_programming/fast_fibonacci.py
@@ -8,14 +8,14 @@


# returns F(n)
def fibonacci(n: int): # noqa: E999 This syntax is Python 3 only
def fibonacci(n: int) -> int: # noqa: E999 This syntax is Python 3 only

This comment has been minimized.

Sign in to view
Copy link
@cclauss

cclauss Apr 17, 2020

Member

Please lose the noqa comments here and below because Python 2 is dead.

This comment has been minimized.

Sign in to view
Copy link
@hugolmn

hugolmn Apr 19, 2020

As encouraged in the Coding Style section of CONTRIBUTING.md

Please write in Python 3.7+

So I agree with @cclauss comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@hugolmn hugolmn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SandersLin @cclauss @hugolmn
You can’t perform that action at this time.