Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert PR 1440, do not modify cookie value #5459
Closed
Conversation
|
At this point the behaviour is too ingrained to be reverted arbitrarily and would need to wait for a major version release which is not planned to the best of my knowledge |
|
This functionality has been in the library for 7 years now, so we can't pull it out without breaking users. If we were to ever put another major version up, this could possibly be looked at, but I don't think we can merge this in 2.x. Thanks for the suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yanxurui commentedMay 15, 2020
Revert PR #1440 as discussed in issue #3759
It does not make sense to modify the cookie value arbitrarily.