Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change work with parent classes. Revise supported php versions #382

Conversation

@vkhramtsov
Copy link

vkhramtsov commented Dec 7, 2019

  • Fix checking and calling for parent in classes, which does not have parent
  • Remove checking for parent class in classes, which extend other casses
  • Remove outdated php versions
  • Add actual php versions
  • Fix tests (count on classes)
@alexndr-novikov
Copy link

alexndr-novikov commented Dec 9, 2019

Very helpful, cause to work on PHP 7.4 we had to patch the library to avoid crash on parent:: usage in context of not child class
Thanks, @vkhramtsov , I hope this PR will be accepted and merged soon

Copy link

alexndr-novikov left a comment

We use patch like this in our project and it works pretty good (PHP7.4)

@vkhramtsov
Copy link
Author

vkhramtsov commented Dec 11, 2019

@kikmak42 Would you be so kind to review and merge this PR or point to valid person for it?

@vkhramtsov
Copy link
Author

vkhramtsov commented Dec 13, 2019

@gnongsie Would you be so kind to help me with this PR?

@vkhramtsov
Copy link
Author

vkhramtsov commented Dec 26, 2019

Is this repo dead or alive?

@stevedesmond-ca
Copy link

stevedesmond-ca commented Jan 1, 2020

Also trying to upgrade our app to PHP 7.4 and blocked on this issue -- paging other recent contributors @brianmc and @ashtru: any news on this?

@dranes
Copy link

dranes commented Jan 30, 2020

We moved our application to 7.4, and now we can't use Authorize.NET 😢 any news on this?

@carloslahrssen
Copy link

carloslahrssen commented Jan 30, 2020

Currently being blocked by this, it's kind of crazy that there's been no activity from the maintainers since this has been opened. Seeing that the last commit on this repo was in June, I feel like that my team has no choice but to fork and apply the changes ourselves.

@stevedesmond-ca
Copy link

stevedesmond-ca commented Jan 31, 2020

I don't know that this PR will be merged, as it modifies generated code, rather than updating the generator, which I'm not positive is possible, given what it needs to know.

As a workaround, we currently briefly set error_reporting (E_ALL & ~E_DEPRECATED) while the questionable code runs, then revert back to error_reporting (E_ALL) once it's done.

@vkhramtsov
Copy link
Author

vkhramtsov commented Jan 31, 2020

@stevedesmond-ca Would you be so kind to supply me with the link to generator and documentation for it?

@dranes
Copy link

dranes commented Mar 24, 2020

I have tested this code un production too looks good, any news on this?

@sharik709
Copy link

sharik709 commented Apr 22, 2020

I've having problems because of this. Not sure why it's not merged. Anyone has any idea how to get this pull request merged to my forked version or use package based off of this pull request?

Edit: Found it https://stackoverflow.com/questions/25878984/can-i-pull-a-specific-commit-with-composer Thanks :)

@dranes
Copy link

dranes commented Apr 22, 2020

@shahariaazam yes in your composer.json you need to add in the require section

 "authorizenet/authorizenet": "dev-bugfix-remove-parent-call-when-class-does-not-have-parent"

and then in the "repositories" section

"repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:vkhramtsov/sdk-php.git",
            "no-api": true
        }]
@sharik709
Copy link

sharik709 commented Apr 23, 2020

@dranes Thank you :)

@jgile
Copy link

jgile commented Apr 25, 2020

authorize.net... surely you can afford to hire a single PHP developer to handle this package. it seriously needs some support. I'll do it. Just hand it over, please.

@dranes
Copy link

dranes commented Apr 25, 2020

Should we create a Patreon for this package?

@anuradhan
Copy link

anuradhan commented May 1, 2020

i tried these and still got error on PHP 7.4
had to downgrade php from 7.4 to 7.3 to get Authorize master version to work.

@sharik709
Copy link

sharik709 commented May 5, 2020

@anuradhan i'm unsure how you did it. But this is how I solved it.

delete composer.lock

delete vendor

add
"authorizenet/authorizenet": "dev-master#ef297d3e2d7c1092ddabd2c376eb485aac1aa66c"
to composer.json require section.

run composer install

obliviously, you should be careful on production and install it properly but that's how i did it in my development env.

Enjoy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.