Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Drop, Out to VisualStudio.gitignore #3392

Open
wants to merge 3 commits into
base: master
from

Conversation

@abatishchev
Copy link

@abatishchev abatishchev commented Apr 30, 2020

Reasons for making this change:

Stands for Drop/drop.

Stands for Drop/drop.
@shiftkey
Copy link
Member

@shiftkey shiftkey commented May 1, 2020

@abatishchev any links to StackOverflow discussions or other documentation about this change?

@shiftkey shiftkey added the needs info label May 1, 2020
@abatishchev
Copy link
Author

@abatishchev abatishchev commented May 1, 2020

I think it should be both /out and /drop.

I don't have a discussion on Stack Overflow but internally at Microsoft it's a common practice to move the build drop folder to the root of the project and l these two folders are the most popular folder names for that.

@abatishchev abatishchev changed the title Added [Dd]rop to VisualStudio.gitignore Added Drop, Out to VisualStudio.gitignore May 7, 2020
@abatishchev
Copy link
Author

@abatishchev abatishchev commented May 16, 2020

@shiftkey, ping.

VisualStudio.gitignore Outdated Show resolved Hide resolved
@shiftkey
Copy link
Member

@shiftkey shiftkey commented May 18, 2020

I don't have a discussion on Stack Overflow but internally at Microsoft it's a common practice to move the build drop folder to the root of the project and l these two folders are the most popular folder names for that.

@abatishchev this is still rather unsatisfying for me, because if I were to merge this and someone asks why we made this change I don't have anything to point to beyond this quote. Does that help clarify my situation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants