Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix redirect loop in Chrome 80 #2509
Conversation
This fixes the following error message from Chrome 80 A cookie associated with a cross-site resource at http://zeronet.example.com/ was set without the `SameSite` attribute. It has been blocked, as Chrome now only delivers cookies with cross-site requests if they are set with `SameSite=None` and `Secure`. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
|
Will it work without https? |
no, it won't. I guess we need to add something to fix that. |
|
Perhaps using config options is not the correct solution, because then either HTTP or HTTPS will break. What if we make the browser send the protocol to the server? |
That would work I guess but I am not sure how we want to do this. I don't think there is a header for this except if you run it behind a reverse proxy which might set |
|
We could just use JavaScript on the client side. |
|
Lots of people use Chrome even if we don't like it. We should fix problems if want ZeroNet to be widely used. |
well, I don't think I can do this in a proper clean way in ZeroNet right now. Help would be appreciated. |
Then ZeroNet is dead in 5 years, most 10.
For that matter. According to Chromestatus Firefox is going to follow that soon so Tor is going to get that change eventually, too. Didn't find a confirmation in the source tough. Also the Change is not some random change from the Chromium or Google people but a standard they follow and I do not think ZeroNet should stand against standards for no good reason.
It is neither based on Firefox or Chromium so I won't support that. An addon to Firefox or Tor or a fork of one of them would be perfectly fine and wouldn't need a reimplementation of such a complex thing as a browser.
Then the password plugin will be broken as soon as Firefox follow the new standard. To bad but I want password protection infront of my zeronet. This also has nothing to do with Windows and technically I already forked ZeroNet and I have no intent to fork it just to fix this nitty little bug. Also this is probably in Chromium already (didn't test) so we just excluded a vast majority of all people using zeronet with password authentication. |
Yes. When you remove all those things, rename it to "zero". |
And now for something completely different: this patch changes the plugin, not the core. |
then remove it and don't offer it at all. Chromium is also effected. Just tested it. If you know what the right solution would be to fix this in the password plugin without affecting the core I am more than welcome to accept it. But this was the fastest and easiest solution to fix my problem and I just wanted to make sure it gets fixed upstream as well. and I think you are getting a bit off topic here. Sure there are more important things to do but this would have been an easy fix where we don't need to argue over and over again but just do it and get over it. Edit: Back to topic: Secure and samesite=none can only be set on https so this would break the login on http sites as the cookie then wouldn't be set at all. |
|
One solution could be a built-in let's encrypt client for https cert, but as far as I know let's encrypt does not support cert for IP addresses, so it would require a domain name. The cookie based authentication has other issues (Eg. it's missing from custom font file requests), so some better alternative would be great. |
|
@SuperSandro2000 set up a reverse-proxy and than you can use letsencrypt or cookies (add headers to the proxy or gateway as you like). @HelloZeroNet on April 8, 2020 renewed the zeronet.io's certificate right after commenting here.
Some sites doesn't use cookies at all! So we don't need cookies in ZeroNet just to satisfy Google... |
|
@warcriminal I have that already and the plugin would still break.
Which does not work for login protection from non static IPs without having some sort of certificate or cookie or you enter the login details for every request. |
|
I think 36d96d4 closed this issue. Closing for now. |
This fixes the following error message from Chrome 80
A cookie associated with a cross-site resource at http://zeronet.example.com/ was set without the
SameSiteattribute. It has been blocked, as Chrome now only delivers cookies with cross-site requests if they are set withSameSite=NoneandSecure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.