Skip to content

/ assemblyscript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter for AssemblyScript #991

Open
MaxGraey opened this issue Dec 6, 2019 · 4 comments
Open

Linter for AssemblyScript #991

MaxGraey opened this issue Dec 6, 2019 · 4 comments
Labels
enhancement good first issue help wanted tools

Comments

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Dec 6, 2019 •
edited

On recent bi-weekly meeting we talked about lint system. Currently we have very basic rules for ts-lint but first of all it only for internal usage and development process, secondary it pretty basic and don't cover all special cases and finally it based on ts-lint which not so powerful as eslint which already supported by typescript. So basic plan:

  1. Migrate to eslint;
  2. Add more custom rules via plugins (need further discussion);
  3. Add default preset;
  4. Publish it to npm as @assemblyscript/linter?
@willemneal
Copy link
Contributor

@willemneal willemneal commented Dec 6, 2019

Should we also consider publishing other things such as the loader with the same namespace?
@MaxGraey
Copy link
Member Author

@MaxGraey MaxGraey commented Dec 6, 2019 •
edited

loader already published under @assemblyscript namespace.
@willemneal
Copy link
Contributor

@willemneal willemneal commented Dec 6, 2019

Oh didn't know that. Cool!
@hugo-dc hugo-dc mentioned this issue Dec 11, 2019
Open
@webmaster128
Copy link

@webmaster128 webmaster128 commented Jan 17, 2020

The commit CosmWasm/cosmwasm@d0e1a2c contains an AssemblyScript setup with eslint + prettier + eslint-plugin-simple-import-sort. yarn lint runs the checks and yarn lint --fix fixes them, which also applies all the prettier rules. It works with the dbaeumer.vscode-eslint VSCode plugin and its auto-fixer. Feel free to borrow from that config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted tools
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@MaxGraey @willemneal @webmaster128
You can’t perform that action at this time.