Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
added start script to electron demo #1200
Open
Conversation
when I run the application without this line
"scripts": {
"start": "electron ."
},
it doesn't work and it gives me an error saying that the start script is missing.
|
The command is buried in the Makefile but it probably makes more sense as npm scripts .PHONY: run
run:
electron .There's a lint command that probably should also be added to the package.json: .PHONY: lint
lint:
eslint *.jsCan you also change the makefile so that it runs the npm script: .PHONY: lint
lint:
npm run lint
.PHONY: run
run:
npm startFinally, can you change the commit message to indicate that this is for the electron demo, something like "added start script to electron demo" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
when I run the application without this line
"scripts": {
"start": "electron ."
},
it doesn't work and it gives me an error saying that the start script is missing.