Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add support for node version codenames and keywords #58
Conversation
Refactored for optimization and maintainability
|
Suggestion: Since the refactoring done in this PR interferes with #42, I could also incorporate those changes in this PR. Edit: I also didn't update |
|
|
|
This PR seems to have a lot of out of scope changes in it. |
|
Not going to update it if it's not going to be merged. |
|
Why is this not merged? It would be important to me to indicate that I want my tests to run on the latest LTS node version. Right now I need to update it everywhere by hand. |
Resolves #26
This PR adds support for node codenames (
argon,boronetc) and selected keywords (latest,current,lts).Resolving the codenames and keywords is fully automated and ensures future codenames support.
In order to do so, I took the liberty to refactor the code and test cases for better optimization and maintainability.
I'm aware that code reviewing will be a nightmare because of the many changes. I suggest having a look at the new code itself instead, to have a better understanding of it.
In case the refactoring is not acceptable, I'll try to provide a PR with minimum changes, but the code will be ugly.