Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[guide] [react] HOC WrappedComponent static property #1537
Conversation
|
|
||
| ## High-Order Components | ||
|
|
||
| - For [Higher-Order Components](https://facebook.github.io/react/docs/higher-order-components.html) define static property `WrappedComponent` as a reference to decorated component. |
This comment has been minimized.
This comment has been minimized.
ljharb
Aug 25, 2017
Collaborator
This link doesn't suggest adding this static property. Where is this convention coming from?
|
|
||
| - For [Higher-Order Components](https://facebook.github.io/react/docs/higher-order-components.html) define static property `WrappedComponent` as a reference to decorated component. | ||
|
|
||
| If your High-Order Components don't provide access to decorated components, you can get faced with issue of [`import/no-named-as-default`](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default.md) |
This comment has been minimized.
This comment has been minimized.
ljharb
Aug 25, 2017
Collaborator
This isn't really a problem due to enzyme's .dive() method - "wrapped" components no longer need to be directly exported for the same of tests.
| ```jsx | ||
| // Title.test.jsx | ||
| import Title from './Title'; | ||
| shallow(<Title.WrappedComponent>Hello, World!</Title.WrappedComponent> |
This comment has been minimized.
This comment has been minimized.
ljharb
Aug 25, 2017
Collaborator
specifically, shallow(<Title />).dive() is the proper way to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nakhodkin commentedAug 24, 2017
WrappedComponentstatic property should be added to custom High-Order component to get access to the initial(decorated component). In most cases it would allow to avoid issueimport/no-named-as-default