Skip to content
Apache Spark - A unified analytics engine for large-scale data processing
Scala Java Python HiveQL R TSQL Other
Branch: master
Clone or download

Latest commit

maropu and cloud-fan [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null
### What changes were proposed in this pull request?

This PR intends to fix a bug of `Dataset.map` below when the whole-stage codegen enabled;
```
scala> val ds = Seq(1.asInstanceOf[Integer], null.asInstanceOf[Integer]).toDS()

scala> sql("SET spark.sql.codegen.wholeStage=true")

scala> ds.map(v=>(v,v)).explain
== Physical Plan ==
*(1) SerializeFromObject [assertnotnull(input[0, scala.Tuple2, true])._1.intValue AS _1#69, assertnotnull(input[0, scala.Tuple2, true])._2.intValue AS _2#70]
+- *(1) MapElements <function1>, obj#68: scala.Tuple2
   +- *(1) DeserializeToObject staticinvoke(class java.lang.Integer, ObjectType(class java.lang.Integer), valueOf, value#1, true, false), obj#67: java.lang.Integer
      +- LocalTableScan [value#1]

// `AssertNotNull` in `SerializeFromObject` will fail;
scala> ds.map(v => (v, v)).show()
java.lang.NullPointerException: Null value appeared in non-nullable fails:
top level Product input object
If the schema is inferred from a Scala tuple/case class, or a Java bean, please try to use scala.Option[_] or other nullable types (e.g. java.lang.Integer instead of int/scala.Int).

// When the whole-stage codegen disabled, the query works well;
scala> sql("SET spark.sql.codegen.wholeStage=false")
scala> ds.map(v=>(v,v)).show()
+----+----+
|  _1|  _2|
+----+----+
|   1|   1|
|null|null|
+----+----+
```
A root cause is that `Invoke` used in `MapElementsExec` propagates input null, and then [AssertNotNull](https://github.com/apache/spark/blob/1b780f364bfbb46944fe805a024bb6c32f5d2dde/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala#L253-L255) in `SerializeFromObject` fails because a top-level row becomes null. So, `MapElementsExec` should not return `null` but `(null, null)`.

NOTE: the generated code of the query above in the current master;
```
/* 033 */   private void mapelements_doConsume_0(java.lang.Integer mapelements_expr_0_0, boolean mapelements_exprIsNull_0_0) throws java.io.IOException {
/* 034 */     boolean mapelements_isNull_1 = true;
/* 035 */     scala.Tuple2 mapelements_value_1 = null;
/* 036 */     if (!false) {
/* 037 */       mapelements_resultIsNull_0 = false;
/* 038 */
/* 039 */       if (!mapelements_resultIsNull_0) {
/* 040 */         mapelements_resultIsNull_0 = mapelements_exprIsNull_0_0;
/* 041 */         mapelements_mutableStateArray_0[0] = mapelements_expr_0_0;
/* 042 */       }
/* 043 */
/* 044 */       mapelements_isNull_1 = mapelements_resultIsNull_0;
/* 045 */       if (!mapelements_isNull_1) {
/* 046 */         Object mapelements_funcResult_0 = null;
/* 047 */         mapelements_funcResult_0 = ((scala.Function1) references[1] /* literal */).apply(mapelements_mutableStateArray_0[0]);
/* 048 */
/* 049 */         if (mapelements_funcResult_0 != null) {
/* 050 */           mapelements_value_1 = (scala.Tuple2) mapelements_funcResult_0;
/* 051 */         } else {
/* 052 */           mapelements_isNull_1 = true;
/* 053 */         }
/* 054 */
/* 055 */       }
/* 056 */     }
/* 057 */
/* 058 */     serializefromobject_doConsume_0(mapelements_value_1, mapelements_isNull_1);
/* 059 */
/* 060 */   }
```

The generated code w/ this fix;
```
/* 032 */   private void mapelements_doConsume_0(java.lang.Integer mapelements_expr_0_0, boolean mapelements_exprIsNull_0_0) throws java.io.IOException {
/* 033 */     boolean mapelements_isNull_1 = true;
/* 034 */     scala.Tuple2 mapelements_value_1 = null;
/* 035 */     if (!false) {
/* 036 */       mapelements_mutableStateArray_0[0] = mapelements_expr_0_0;
/* 037 */
/* 038 */       mapelements_isNull_1 = false;
/* 039 */       if (!mapelements_isNull_1) {
/* 040 */         Object mapelements_funcResult_0 = null;
/* 041 */         mapelements_funcResult_0 = ((scala.Function1) references[1] /* literal */).apply(mapelements_mutableStateArray_0[0]);
/* 042 */
/* 043 */         if (mapelements_funcResult_0 != null) {
/* 044 */           mapelements_value_1 = (scala.Tuple2) mapelements_funcResult_0;
/* 045 */           mapelements_isNull_1 = false;
/* 046 */         } else {
/* 047 */           mapelements_isNull_1 = true;
/* 048 */         }
/* 049 */
/* 050 */       }
/* 051 */     }
/* 052 */
/* 053 */     serializefromobject_doConsume_0(mapelements_value_1, mapelements_isNull_1);
/* 054 */
/* 055 */   }
```

### Why are the changes needed?

Bugfix.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Added tests.

Closes #28681 from maropu/SPARK-31854.

Authored-by: Takeshi Yamamuro <yamamuro@apache.org>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Latest commit b806fc4 Jun 1, 2020

Files

Permalink
Type Name Latest commit message Commit time
Failed to load latest commit information.
.github [MINOR][INFRA] Add a guide to clarify release/unreleased Spark versio… Apr 30, 2020
R [SPARK-31701][R][SQL] Bump up the minimum Arrow version as 0.15.1 in … May 13, 2020
assembly [SPARK-30950][BUILD] Setting version to 3.1.0-SNAPSHOT Feb 26, 2020
bin [SPARK-31401][K8S] Show JDK11 usage in `bin/docker-image-tool.sh` Apr 10, 2020
build [SPARK-31041][BUILD] Show Maven errors from within make-distribution.sh Mar 11, 2020
common [SPARK-31756][WEBUI] Add real headless browser support for UI test May 29, 2020
conf [SPARK-31759][DEPLOY] Support configurable max number of rotate logs … May 20, 2020
core [SPARK-31756][WEBUI] Add real headless browser support for UI test May 29, 2020
data [SPARK-22666][ML][SQL] Spark datasource for image format Sep 5, 2018
dev [SPARK-31858][BUILD] Upgrade commons-io to 2.5 in Hadoop 3.2 profile May 29, 2020
docs [SPARK-31867][SQL] Disable year type datetime patterns which are long… May 31, 2020
examples [SPARK-31708][ML][DOCS] Add docs and examples for ANOVASelector and F… May 15, 2020
external [SPARK-31855][SQL][TESTS] Check reading date/timestamp from Avro file… May 29, 2020
graphx [SPARK-30950][BUILD] Setting version to 3.1.0-SNAPSHOT Feb 26, 2020
hadoop-cloud [SPARK-30950][BUILD] Setting version to 3.1.0-SNAPSHOT Feb 26, 2020
launcher [SPARK-30950][BUILD] Setting version to 3.1.0-SNAPSHOT Feb 26, 2020
licenses-binary [SPARK-31420][WEBUI] Infinite timeline redraw in job details page Apr 14, 2020
licenses [SPARK-31420][WEBUI] Infinite timeline redraw in job details page Apr 14, 2020
mllib-local [SPARK-30699][ML][PYSPARK] GMM blockify input vectors May 12, 2020
mllib [SPARK-31840][ML] Add instance weight support in LogisticRegressionSu… May 31, 2020
project [SPARK-31840][ML] Add instance weight support in LogisticRegressionSu… May 31, 2020
python [SPARK-31849][PYTHON][SQL] Make PySpark SQL exceptions more Pythonic Jun 1, 2020
repl [SPARK-31399][CORE][TEST-HADOOP3.2][TEST-JAVA11] Support indylambda S… May 18, 2020
resource-managers [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2 May 23, 2020
sbin [SPARK-31759][DEPLOY] Support configurable max number of rotate logs … May 20, 2020
sql [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null Jun 1, 2020
streaming Revert "[SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0" May 21, 2020
tools [SPARK-30950][BUILD] Setting version to 3.1.0-SNAPSHOT Feb 26, 2020
.asf.yaml [SPARK-31352] Add .asf.yaml to control Github settings Apr 6, 2020
.gitattributes [SPARK-30653][INFRA][SQL] EOL character enforcement for java/scala/xm… Jan 27, 2020
.gitignore Revert "[SPARK-30879][DOCS] Refine workflow for building docs" Mar 31, 2020
CONTRIBUTING.md [MINOR][DOCS] Tighten up some key links to the project and download p… May 21, 2019
LICENSE [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for JDK 9+ Nov 3, 2019
LICENSE-binary [SPARK-30695][BUILD] Upgrade Apache ORC to 1.5.9 Feb 1, 2020
NOTICE [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for JDK 9+ Nov 3, 2019
NOTICE-binary [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for JDK 9+ Nov 3, 2019
README.md [MINOR][DOCS] Fix Jenkins build image and link in README.md Jan 21, 2020
appveyor.yml [SPARK-31744][R][INFRA] Remove Hive dependency in AppVeyor build temp… May 18, 2020
pom.xml [SPARK-31756][WEBUI] Add real headless browser support for UI test May 29, 2020
scalastyle-config.xml [SPARK-30030][INFRA] Use RegexChecker instead of TokenChecker to chec… Nov 25, 2019

README.md

Apache Spark

Spark is a unified analytics engine for large-scale data processing. It provides high-level APIs in Scala, Java, Python, and R, and an optimized engine that supports general computation graphs for data analysis. It also supports a rich set of higher-level tools including Spark SQL for SQL and DataFrames, MLlib for machine learning, GraphX for graph processing, and Structured Streaming for stream processing.

https://spark.apache.org/

Jenkins Build AppVeyor Build PySpark Coverage

Online Documentation

You can find the latest Spark documentation, including a programming guide, on the project web page. This README file only contains basic setup instructions.

Building Spark

Spark is built using Apache Maven. To build Spark and its example programs, run:

./build/mvn -DskipTests clean package

(You do not need to do this if you downloaded a pre-built package.)

More detailed documentation is available from the project site, at "Building Spark".

For general development tips, including info on developing Spark using an IDE, see "Useful Developer Tools".

Interactive Scala Shell

The easiest way to start using Spark is through the Scala shell:

./bin/spark-shell

Try the following command, which should return 1,000,000,000:

scala> spark.range(1000 * 1000 * 1000).count()

Interactive Python Shell

Alternatively, if you prefer Python, you can use the Python shell:

./bin/pyspark

And run the following command, which should also return 1,000,000,000:

>>> spark.range(1000 * 1000 * 1000).count()

Example Programs

Spark also comes with several sample programs in the examples directory. To run one of them, use ./bin/run-example <class> [params]. For example:

./bin/run-example SparkPi

will run the Pi example locally.

You can set the MASTER environment variable when running examples to submit examples to a cluster. This can be a mesos:// or spark:// URL, "yarn" to run on YARN, and "local" to run locally with one thread, or "local[N]" to run locally with N threads. You can also use an abbreviated class name if the class is in the examples package. For instance:

MASTER=spark://host:7077 ./bin/run-example SparkPi

Many of the example programs print usage help if no params are given.

Running Tests

Testing first requires building Spark. Once Spark is built, tests can be run using:

./dev/run-tests

Please see the guidance on how to run tests for a module, or individual tests.

There is also a Kubernetes integration test, see resource-managers/kubernetes/integration-tests/README.md

A Note About Hadoop Versions

Spark uses the Hadoop core library to talk to HDFS and other Hadoop-supported storage systems. Because the protocols have changed in different versions of Hadoop, you must build Spark against the same version that your cluster runs.

Please refer to the build documentation at "Specifying the Hadoop Version and Enabling YARN" for detailed guidance on building for a particular distribution of Hadoop, including building for particular Hive and Hive Thriftserver distributions.

Configuration

Please refer to the Configuration Guide in the online documentation for an overview on how to configure Spark.

Contributing

Please review the Contribution to Spark guide for information on how to get started contributing to the project.

You can’t perform that action at this time.