Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged redis backend to use aioredis instead of asyncio_redis. #8
Conversation
broadcaster/_backends/redis.py
Outdated
| await self._pub_conn.publish(channel, message) | ||
| await self._pub_conn.publish_json(channel, message) | ||
|
|
||
| async def _wait_for_channel(self) -> None: |
Woile
Feb 27, 2020
Contributor
I would try to find a way to avoid this. With async-redis it was possible, so I guess it should be possible to do it with aioredis, what do you think?
I would try to find a way to avoid this. With async-redis it was possible, so I guess it should be possible to do it with aioredis, what do you think?
hramezani
Feb 28, 2020
Author
Contributor
Thanks, @Woile. It would be good to find a solution because we have the same problem in redis-stream backend.
Maybe we need to change the way of subscription on the base class. what do you think?
Thanks, @Woile. It would be good to find a solution because we have the same problem in redis-stream backend.
Maybe we need to change the way of subscription on the base class. what do you think?
hramezani
Mar 8, 2020
Author
Contributor
I have moved listener_task creation from connect to subscribe. now we don't need the _wait_for_channel function.
I have moved listener_task creation from connect to subscribe. now we don't need the _wait_for_channel function.
hramezani
force-pushed the
hramezani:change_redis_backend
branch
from
cac3b42
to
dbef3c3
hramezani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Based on @tomchristie comment.
I have added
await self._wait_for_channel(), to wait for the channel.