Skip to content
#

protocol

Here are 1,297 public repositories matching this topic...

sako0938
sako0938 commented Oct 14, 2019

Background

The binaries are built with most of the build flags already set, but when building from source you must specify which tags are desired. This is an important step to building a usable binary from source.

These flags should be listed in the docs, with what their use is for the entire system, and whether or not excluding it would break the normal function of the system.

A sect

lbry-sdk
ELLIOTTCABLE
ELLIOTTCABLE commented Feb 29, 2020

On macOS, it's a fairly standard practice to display a pre-roll if your application needs some form of permissions, before calling the system APIs for the first time that will actually produce the system's requested-permissions window.

For instance, for any given end-user, the following window is likely A) intimidating, and B) possibly encourages insecure habits, such as simply clicking "acce

nibanks
nibanks commented Feb 18, 2020

While looking at the code, I noticed there are several failure paths in the QuicPacketBuilderFinalize function that don't result in the current packet metadata being cleaned up. It could have a reference to a stream, which doesn't get released. This will at best leak additional memory, and at worst cause a hang in clean up.

AnthonyMillerSF
AnthonyMillerSF commented Apr 16, 2020

I have a library that I generate all of my mocks into that is imported in my unit tests. When mocking a protocol, the generated mock object doesn't have an initializer declared. This means is uses the default initializer, which would be fine, except the default init() method is internal. I can get around this by importing my mock library @testable, but I'd suggest that protocol mocks for publi

Ralith
Ralith commented May 4, 2020

We currently issue flow control credit immediately upon application-layer consumption of data. This is excessive; we could slightly reduce overhead by instead issuing flow control credit when the amount that would be issued is at least a certain proportion of the entire window.

sbtc1
sbtc1 commented Aug 18, 2019

The reference documentation does not mention the possibility of using a capitalised invoice (eg LNBC..), still most implementations in the wild seem to accept them.

There are good reasons to support capitalised invoices, like smaller QR codes.

My suggestion is to explicitely mention in the documentation that invoices should be case-independant so that implementations must allow both forms (

ipfs-companion

Improve this page

Add a description, image, and links to the protocol topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the protocol topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.