Fixes FlutterEngine internal retain cycle #18595
Merged
Conversation
|
LGTM, thanks for the contribution! |
|
Please make the aforementioned performance changes. |
| }]; | ||
|
|
||
| auto platformViewsController = _platformViewsController.get(); |
gaaclarke
Jun 16, 2020
Contributor
This one should still use the weakptr trick you were using previously. The reason is that platformViewsController is a C++ object which means it won't get retained when it is captured by the block. In practice this looks like it would be safe today but I think we should err on the side of caution.
This one should still use the weakptr trick you were using previously. The reason is that platformViewsController is a C++ object which means it won't get retained when it is captured by the block. In practice this looks like it would be safe today but I think we should err on the side of caution.
|
Nice! Thanks for the quick responses =) |
|
Landing on red, the CI failure was a flake. It passed when rerun here: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/aaclarke_google.com/a96bf18d97c25854a608cf5e25f0bd8ce76c3a567885d6fcdce4aef30bb56b4b/+/annotations?server=chromium-swarm.appspot.com |
gaaclarke
merged commit d7d9e8b
into
flutter:master
20 of 21 checks passed
20 of 21 checks passed
cla/google
All necessary CLAs are signed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
This was referenced Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.