Skip to content
#

assert

Here are 316 public repositories matching this topic...

ava
atrium
robstoll
robstoll commented Apr 28, 2020

Platform (jvm, js, android): jvm
Extension (none, kotlin 1.3, jdk8): jdk8

Code related feature

expect(ZonedDateTime.now()).isAfter("2020-04-28T12:00Z")

//instead of

expect(ZonedDateTime.now()).isAfter(ZonedDateTime.of(2020,4,28,12,0,0,0, ZoneId.of("Z")))

Following the things you need to do:

atrium-logic:

  • duplicate each method in chronoZonedDateTimeAsserti
klosworks
klosworks commented Aug 16, 2019

"The library is designed to be lightweight would you decide to keep assertions enabled even in release builds (#define PPK_ASSERT_ENABLED 1)"

Unless I don't know something about English language, you need some joining word before "would". Also, the use of "would" is a bit weird here.
It should be something like
"The library is designed to be lightweight so that you can keep assertions en

Ocramius
Ocramius commented Dec 2, 2019

Assert::implementsInterface() works on object|string, not just object, so it should be translated to something like assert($foo instanceof $type || in_array($interface, \class_implements($value))) (see https://3v4l.org/VdIbR).

Not sure what the correct translation (understood by PHPStan) would be.

For reference, this is the current implementation:

https://github.com/phpstan/phpsta

emil13
emil13 commented Jan 18, 2018

We just upgraded to React16 and as a consequence updated quite a number of our libraries. In the test cases we started seeing this error:

undefined is not an enzyme wrapper

In assertions.js/isEnzymeWrapper(); expect-enzyme looks for the actual property which used to be present on the Expectation object returned when you called expect(something). expect() no longer returns an Expectation

gundelsby
gundelsby commented Feb 21, 2020

What did you expect to happen?
Documentation should be up to date.
Error messages from assertions should be accurate.

What actually happens
Documentation still lists the predefined assert defined, and not isUndefined.

Improve this page

Add a description, image, and links to the assert topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the assert topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.