Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConsistent PR lookup interface #1020
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
probablycorey commentedMay 27, 2020
We've got a few ways to get a PR object right now, and they are all slightly different and require a lot of boilerplate code. This creates a consistent interface for that lookup. It might sound familiar because I tried it before in #926 but this time it will work!
The plan
This is going to be a two step process.
Get the commands using the same pr lookup interface
prFromArgs. This will look at the commands args to find the PR via a number, url, branch name or whatever the current branch of the existing git repo is. This is what I solved in this PR.Add an argument to
prFromArgsthat lets you pick what type of PR response you want back. This was mislav's magical reflection idea that we got working in https://github.com/cli/cli/compare/pr-get-queryThings I considered while writing this.
prFromArgsbecause if passed the string itself likeargs[0]we'd get a panic when there are no args or we'd need a conditional before each call. This seemed annoying and passing the args array worked out well enough.