Skip to content

/ firebase-android-sdk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FIAM Display lifecycle interactions #1550

Merged
merged 7 commits into from May 12, 2020
Merged

Fix FIAM Display lifecycle interactions #1550

merged 7 commits into from May 12, 2020

Conversation

@JasonAHeron
Copy link
Contributor

JasonAHeron commented May 11, 2020

Fixes: #1410
Fixes: #1092
@googlebot googlebot added the cla: yes label May 11, 2020
@JasonAHeron JasonAHeron requested a review from prakhar1989 May 11, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 11, 2020 •
edited

Coverage Report

Affected SDKs

  • firebase-inappmessaging

    SDK overall coverage changed from 34.29% (9d75839) to 34.27% (58e68ec5) by -0.02%.

    Filename Base (9d75839) Head (58e68ec5) Diff
    DeveloperListenerManager.java 92.50% 88.10% -4.40%
    FirebaseInAppMessaging.java 63.16% 61.02% -2.14%

  • firebase-inappmessaging-display

    SDK overall coverage changed from 32.30% (9d75839) to 32.84% (58e68ec5) by +0.54%.

    Filename Base (9d75839) Head (58e68ec5) Diff
    FirebaseInAppMessagingDisplay.java 84.16% 87.50% +3.34%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (58e68ec5) is created by Prow via merging commits: 9d75839 1ecc6cf.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 11, 2020

The public api surface has changed for the subproject firebase-inappmessaging:
error: Added method com.google.firebase.inappmessaging.FirebaseInAppMessaging.triggerEvent(String) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.
1 similar comment
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 11, 2020

The public api surface has changed for the subproject firebase-inappmessaging:
error: Added method com.google.firebase.inappmessaging.FirebaseInAppMessaging.triggerEvent(String) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.
@JasonAHeron JasonAHeron requested a review from ashwinraghav May 11, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 11, 2020 •
edited

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (aggressive) 85.3 kB 85.3 kB -15 B (-0.0%)
    apk (debug) 894 kB 894 kB +53 B (+0.0%)

  • firebase-common

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (aggressive) 82.5 kB 82.5 kB +6 B (+0.0%)
    apk (debug) 770 kB 770 kB -21 B (-0.0%)

  • firebase-components

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (debug) 35.9 kB 35.8 kB -33 B (-0.1%)

  • firebase-datatransport

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (aggressive) 117 kB 117 kB +10 B (+0.0%)
    apk (debug) 846 kB 846 kB +19 B (+0.0%)

  • firebase-encoders-json

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (debug) 27.4 kB 27.4 kB -7 B (-0.0%)

  • firebase-inappmessaging

    Type Base (9d75839) Head (58e68ec5) Diff
    aar 473 kB 474 kB +60 B (+0.0%)
    apk (aggressive) 610 kB 610 kB -566 B (-0.1%)
    apk (debug) 4.01 MB 4.01 MB +405 B (+0.0%)
    apk (release) 3.29 MB 3.29 MB -118 B (-0.0%)

  • firebase-inappmessaging-display

    Type Base (9d75839) Head (58e68ec5) Diff
    aar 167 kB 167 kB +267 B (+0.2%)

  • firebase-installations

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (aggressive) 84.2 kB 84.2 kB -10 B (-0.0%)
    apk (debug) 794 kB 794 kB -34 B (-0.0%)

  • firebase-installations-interop

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (aggressive) 61.7 kB 61.7 kB -4 B (-0.0%)
    apk (debug) 744 kB 744 kB -3 B (-0.0%)

  • protolite-well-known-types

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (aggressive) 122 kB 122 kB +7 B (+0.0%)
    apk (debug) 643 kB 643 kB +16 B (+0.0%)

  • transport-api

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (debug) 23.0 kB 23.0 kB -17 B (-0.1%)

  • transport-backend-cct

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (aggressive) 47.8 kB 47.9 kB +15 B (+0.0%)
    apk (debug) 101 kB 101 kB +2 B (+0.0%)

  • transport-runtime

    Type Base (9d75839) Head (58e68ec5) Diff
    apk (aggressive) 35.6 kB 35.5 kB -7 B (-0.0%)
    apk (debug) 80.5 kB 80.5 kB -1 B (-0.0%)

Test Logs

Notes

Head commit (58e68ec5) is created by Prow via merging commits: 9d75839 1ecc6cf.
@prakhar1989
prakhar1989 reviewed May 12, 2020
View changes
...oogle/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Outdated Show resolved Hide resolved
@prakhar1989
prakhar1989 reviewed May 12, 2020
View changes
...oogle/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Outdated Show resolved Hide resolved
@prakhar1989
prakhar1989 reviewed May 12, 2020
View changes
...oogle/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Show resolved Hide resolved
JasonAHeron added 6 commits May 11, 2020
@JasonAHeron
fix display racecondition
Loading status checks…
74b576b
@JasonAHeron
format
Loading status checks…
0dca945
@JasonAHeron
<3
Loading status checks…
a833d0e
@JasonAHeron
add api.txt
Loading status checks…
b01c6a4
@JasonAHeron
kk
Loading status checks…
83aeac5
@JasonAHeron
Address comments
Loading status checks…
b8aaa55
@JasonAHeron JasonAHeron force-pushed the fix_display_racecondition branch from 64206a3 to b8aaa55 May 12, 2020
@eldhosembabu
eldhosembabu reviewed May 12, 2020
View changes
...oogle/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Show resolved Hide resolved
@eldhosembabu
eldhosembabu reviewed May 12, 2020
View changes
...oogle/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Show resolved Hide resolved
@JasonAHeron
address comments
Loading status checks…
1ecc6cf
@JasonAHeron JasonAHeron requested review from vkryachko and removed request for vkryachko May 12, 2020
@ashwinraghav
ashwinraghav approved these changes May 12, 2020
View changes
Copy link
Contributor

ashwinraghav left a comment

Chatted with Json offline.
@JasonAHeron JasonAHeron merged commit 0483b0d into master May 12, 2020
8 checks passed
8 checks passed
api-information Job succeeded.
Details
build-plugins-check Skipped.
check-changed Job succeeded.
Details
cla/google All necessary CLAs are signed
copyright-check Job succeeded.
Details
device-check-changed Job succeeded.
Details
fireci Skipped.
smoke-tests Job succeeded.
Details
@JasonAHeron JasonAHeron deleted the fix_display_racecondition branch May 12, 2020
ashwinraghav added a commit that referenced this pull request May 18, 2020
@JasonAHeron @ashwinraghav
Fix FIAM Display lifecycle interactions (#1550)
Loading status checks…
569fb95
@firebase firebase locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prakhar1989 prakhar1989

@eldhosembabu eldhosembabu

@ashwinraghav ashwinraghav

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

How to configure In-App Messaging to show the message after splash screen
Message is not showing!
6 participants
@JasonAHeron @google-oss-bot @ashwinraghav @prakhar1989 @eldhosembabu @googlebot
You can’t perform that action at this time.