Skip to content

/ Rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCS #96

Open
wants to merge 10 commits into
base: master
from
Open

LCS #96

wants to merge 10 commits into from

Conversation

@Jay9596
Copy link

Jay9596 commented Oct 18, 2019

Re-opened LCS PR and resolved all previous problems.

  • Have good Comments
  • Have full name, instead of LCS
  • Return a String instead of Vec
Jay9596 and others added 10 commits Oct 2, 2018
@Jay9596
Add LCS implementation
Loading status checks…
c0507e0
@Jay9596
Updates :
Loading status checks…
6ca0dc3 
- Add comments
- Add full name in module
@Jay9596
Rename function to longest_common_subsequence
Loading status checks…
10d68db
@AnshulMalik
Merge branch 'master' into LCS
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
43202d8
@AnshulMalik
Merge branch 'master' into LCS
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5b52f95
@AnshulMalik
Merge branch 'master' into LCS
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
537aa47
@Jay9596
Update LCS to match all requirments
d033e98 
- Return String
@Jay9596
Merge pull request #1 from TheAlgorithms/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7b2b6fe 
Update Master
@Jay9596
Merge branch 'LCS' into master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a9f16ce
@Jay9596
Merge pull request #2 from Jay9596/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7381040 
Update LCS for a PR
@phoenisx
Copy link
Contributor

phoenisx commented Oct 21, 2019

Updated PR for - #26

Tracking PR - #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Jay9596 @phoenisx @AnshulMalik
You can’t perform that action at this time.