Add Faker::TvShows::Futurama #1858
Merged
Conversation
|
I'm not sure if we should accept the Hermes class just because I think that's a bit too specific, but other than that this looks good. |
|
@connorshea Thanks for taking a look.
That's a fair argument about the Hermes class, but I have seen other somewhat similar things in some other |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Issue#
No-StoryDescription:
Adds a generator for Futurama, which is one of my favourite TV shows.
This generator can be used to generate names, quotes and locations from Futurama in demo apps, tests, etc. I believe other Futurama fans would use this in their apps and tests, as well as myself.